Skip to content

Conversation

@chambo-e
Copy link
Contributor

@chambo-e chambo-e commented Jul 15, 2021

Should have no impact, we bump as major only for the sake of convenience

BREAKING CHANGE: migrate the codebase to typescript

@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #272 (bc8af84) into master (e14f88f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #272   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          309       311    +2     
  Branches        46        47    +1     
=========================================
+ Hits           309       311    +2     
Impacted Files Coverage Δ
packages/regex/src/index.ts 100.00% <ø> (ø)
packages/use-dataloader/src/constants.ts 100.00% <ø> (ø)
packages/random-name/src/index.ts 100.00% <100.00%> (ø)
packages/use-dataloader/src/DataLoaderProvider.tsx 100.00% <100.00%> (ø)
packages/use-dataloader/src/reducer.ts 100.00% <100.00%> (ø)
packages/use-dataloader/src/useDataLoader.ts 100.00% <100.00%> (ø)
packages/use-i18n/src/formatUnit.ts 100.00% <100.00%> (ø)
packages/use-i18n/src/usei18n.tsx 100.00% <100.00%> (ø)
packages/use-query-params/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14f88f...bc8af84. Read the comment docs.

@chambo-e chambo-e marked this pull request as ready for review July 16, 2021 16:08
@chambo-e chambo-e requested a review from philibea July 16, 2021 16:08
@chambo-e chambo-e self-assigned this Jul 16, 2021
@chambo-e chambo-e merged commit 3923c68 into master Jul 20, 2021
@chambo-e chambo-e deleted the feat/typescript_ branch July 20, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants