Skip to content

Conversation

@chambo-e
Copy link
Contributor

This will allow us to have a global handler for errors

If a onError handler is specified in a useDataloader it will override the one from the Provider

import { DataLoaderProvider, useDataLoader } from '@scaleway-lib/use-dataloader'
import React from 'react'
import ReactDOM from 'react-dom'

const failingPromise = async () => {
  throw new Error('error')
}

const App = () => {
  useDataLoader('local-error',  failingPromise,  {
    onError: (error) => {
      console.log(`local onError: ${error}`)
    }
  })
  
  useDataLoader('error', failingPromise)
  
  return null
}

const globalOnError = (error) => {
  console.log(`global onError: ${error}`)
}

ReactDOM.render(
  <React.StrictMode>
    <DataLoaderProvider onError={globalOnError}>
      <App />
    </DataLoaderProvider>
  </React.StrictMode>,
  document.getElementById('root'),
)

@chambo-e chambo-e requested a review from a team July 21, 2021 09:08
@chambo-e chambo-e self-assigned this Jul 21, 2021
@chambo-e chambo-e requested review from DorianMaliszewski and matthprost and removed request for a team July 21, 2021 09:08
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #286 (e05db99) into master (7ef9832) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #286   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          315       315           
  Branches        49        50    +1     
=========================================
  Hits           315       315           
Impacted Files Coverage Δ
packages/use-dataloader/src/DataLoaderProvider.tsx 100.00% <100.00%> (ø)
packages/use-dataloader/src/useDataLoader.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef9832...e05db99. Read the comment docs.

@chambo-e chambo-e merged commit e881b5e into master Jul 21, 2021
@chambo-e chambo-e deleted the feat/dataloader_onError branch July 21, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants