refactor(use-i18n): use @formatjs/fast-memoize instead of deprecated intl-format-cache #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chambo-e
requested review from
adriengibrat and
vincentaudebert
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 11 +1
Lines 333 345 +12
Branches 55 55
=========================================
+ Hits 333 345 +12
Continue to review full report at Codecov.
|
chambo-e
requested review from
matthprost and
philibea
and removed request for
adriengibrat and
vincentaudebert
chambo-e
force-pushed
the
feat/new_memoize
branch
from
e2c40da to
8515c97
Compare
philibea
approved these changes
Aug 9, 2021
matthprost
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also with some types improvement
Coverage difference is caused by an unused method on our cache, which we need to have to match the TS type
There is a PR open here to correct this formatjs/formatjs#3102