Skip to content

Conversation

@chambo-e
Copy link
Contributor

Closes #499

BREAKING CHANGE: use @scaleway/use-random-name to have the hook version

@chambo-e chambo-e requested a review from a team November 16, 2021 15:33
@chambo-e chambo-e self-assigned this Nov 16, 2021
@chambo-e chambo-e requested review from DorianMaliszewski and vincentaudebert and removed request for a team November 16, 2021 15:33
@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #500 (7832d18) into master (c98e022) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 7832d18 differs from pull request most recent head 0728289. Consider uploading reports for the commit 0728289 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##            master      #500   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        16    +1     
  Lines          483       484    +1     
  Branches        78        79    +1     
=========================================
+ Hits           483       484    +1     
Impacted Files Coverage Δ
packages/random-name/src/index.ts 100.00% <ø> (ø)
packages/use-random-name/src/index.ts 100.00% <100.00%> (ø)
packages/use-query-params/src/index.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50be8b3...0728289. Read the comment docs.

Copy link
Contributor

@vincentaudebert vincentaudebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@philibea philibea enabled auto-merge (squash) November 18, 2021 15:38
@philibea philibea merged commit cf57f2e into master Nov 18, 2021
@philibea philibea deleted the fix/split_random_name branch November 18, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Package random-name is tied up to React

4 participants