Skip to content

feat(eslint-config): add eslint-comments plugin #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2021
Merged

feat(eslint-config): add eslint-comments plugin #534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40f46f5
style: correct some eslint errors before new config rules
chambo-e Dec 8, 2021
447ae8c
feat(eslint-config): add eslint-comments plugin
chambo-e Dec 8, 2021
74553b8
Merge branch 'main' into feat/eslint-comments
chambo-e Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/eslint-config-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"eslint-config-airbnb": "19.0.2",
"eslint-config-airbnb-typescript": "16.1.0",
"eslint-config-prettier": "8.3.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "2.25.3",
"eslint-plugin-jsx-a11y": "6.5.1",
"eslint-plugin-react": "7.27.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/eslint-config-react/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = {
extends: ['airbnb/hooks', 'prettier'],
extends: ['airbnb/hooks', 'prettier', 'plugin:eslint-comments/recommended'],
rules: {
'import/order': [
// https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/order.md
Expand Down
15 changes: 14 additions & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3126,6 +3126,7 @@ __metadata:
eslint-config-airbnb: 19.0.2
eslint-config-airbnb-typescript: 16.1.0
eslint-config-prettier: 8.3.0
eslint-plugin-eslint-comments: ^3.2.0
eslint-plugin-import: 2.25.3
eslint-plugin-jsx-a11y: 6.5.1
eslint-plugin-react: 7.27.1
Expand Down Expand Up @@ -5471,6 +5472,18 @@ __metadata:
languageName: node
linkType: hard

"eslint-plugin-eslint-comments@npm:^3.2.0":
version: 3.2.0
resolution: "eslint-plugin-eslint-comments@npm:3.2.0"
dependencies:
escape-string-regexp: ^1.0.5
ignore: ^5.0.5
peerDependencies:
eslint: ">=4.19.1"
checksum: c9fe273dd56699abdf7e416cfad0344eb50aa01564a5a9133e72d982defb89310bc2e9b0b148ce19c5190d7ff641223b0ba9e667a194bc48467c3dd0d471e657
languageName: node
linkType: hard

"eslint-plugin-import@npm:2.25.3":
version: 2.25.3
resolution: "eslint-plugin-import@npm:2.25.3"
Expand Down Expand Up @@ -6516,7 +6529,7 @@ __metadata:
languageName: node
linkType: hard

"ignore@npm:^5.1.4, ignore@npm:^5.1.8":
"ignore@npm:^5.0.5, ignore@npm:^5.1.4, ignore@npm:^5.1.8":
version: 5.1.9
resolution: "ignore@npm:5.1.9"
checksum: 6f6b2235f4e63648116c5814f76b2d3d63fae9c21b8a466862e865732f59e787c9938a9042f9457091db6f0d811508ea3c8c6a60f35bafc4ceea08bbe8f96fd5
Expand Down