feat(use-i18n): allow default date-fns locale instead of lazy loading #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chambo-e
requested review from
DorianMaliszewski,
adriengibrat and
vincentaudebert
and removed request for
a team and
vincentaudebert
Contributor
Author
|
Needs #546 |
chambo-e
force-pushed
the
fix/default_date_dns
branch
from
8d11f00 to
e5cad9b
Compare
Codecov Report
@@ Coverage Diff @@
## main #547 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 515 514 -1
Branches 86 87 +1
=========================================
- Hits 515 514 -1
Continue to review full report at Codecov.
|
adriengibrat
approved these changes
Dec 20, 2021
philibea
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly intended when use-i18n is used server side, be it on unit tests or ssr.
On first render the provider will load date-fns locale and then rerender, trigger multiple errors on jest because we don't
acton render.When specified a default date-fns locale and no load function provider will not rerender