Skip to content

feat(eslint-config): enable prefer-object-has-own #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 28, 2021
Merged

feat(eslint-config): enable prefer-object-has-own #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1933ecb
feat(eslint-config): enable prefer-object-has-own
chambo-e Dec 27, 2021
0315e91
fix: enable rule
chambo-e Dec 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/eslint-config-react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"dependencies": {
"@typescript-eslint/eslint-plugin": "5.8.1",
"@typescript-eslint/parser": "5.8.1",
"eslint-config-airbnb": "19.0.2",
"eslint-config-airbnb": "19.0.4",
"eslint-config-airbnb-typescript": "16.1.0",
"eslint-config-prettier": "8.3.0",
"eslint-plugin-eslint-comments": "3.2.0",
Expand All @@ -29,6 +29,6 @@
"eslint-plugin-react-hooks": "4.3.0"
},
"peerDependencies": {
"eslint": "7.x || 8.x"
"eslint": ">= 8.5"
}
}
5 changes: 5 additions & 0 deletions packages/eslint-config-react/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
/* eslint-disable sort-keys */

module.exports = {
extends: ['airbnb/hooks', 'prettier', 'plugin:eslint-comments/recommended'],
rules: {
Expand Down Expand Up @@ -57,6 +59,7 @@ module.exports = {
// These are rules soon to be enabled by airbnb react config
// We're getting a head start
'react/no-adjacent-inline-elements': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-adjacent-inline-elements.md
'prefer-object-has-own': 'error', // https://eslint.org/docs/rules/prefer-object-has-own

// To have consistent ordering in proptypes
'react/sort-prop-types': [
Expand All @@ -76,3 +79,5 @@ module.exports = {
'sort-keys': ['error', 'asc', { caseSensitive: false, natural: true }],
},
}

/* eslint-enable sort-keys */
14 changes: 7 additions & 7 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3151,7 +3151,7 @@ __metadata:
dependencies:
"@typescript-eslint/eslint-plugin": 5.8.1
"@typescript-eslint/parser": 5.8.1
eslint-config-airbnb: 19.0.2
eslint-config-airbnb: 19.0.4
eslint-config-airbnb-typescript: 16.1.0
eslint-config-prettier: 8.3.0
eslint-plugin-eslint-comments: 3.2.0
Expand All @@ -3160,7 +3160,7 @@ __metadata:
eslint-plugin-react: 7.28.0
eslint-plugin-react-hooks: 4.3.0
peerDependencies:
eslint: 7.x || 8.x
eslint: ">= 8.5"
languageName: unknown
linkType: soft

Expand Down Expand Up @@ -5493,9 +5493,9 @@ __metadata:
languageName: node
linkType: hard

"eslint-config-airbnb@npm:19.0.2":
version: 19.0.2
resolution: "eslint-config-airbnb@npm:19.0.2"
"eslint-config-airbnb@npm:19.0.4":
version: 19.0.4
resolution: "eslint-config-airbnb@npm:19.0.4"
dependencies:
eslint-config-airbnb-base: ^15.0.0
object.assign: ^4.1.2
Expand All @@ -5504,9 +5504,9 @@ __metadata:
eslint: ^7.32.0 || ^8.2.0
eslint-plugin-import: ^2.25.3
eslint-plugin-jsx-a11y: ^6.5.1
eslint-plugin-react: ^7.27.1
eslint-plugin-react: ^7.28.0
eslint-plugin-react-hooks: ^4.3.0
checksum: 668d91fee4d8e1b7ecefc3844caed6bb77a72b29521dd9595a14abaebb8651439b831da792614b51e7913bbe3b6d20df03e76f52287ccf511dee1982460d3f71
checksum: 253178689c3c80eef2567e3aaf0612e18973bc9cf51d9be36074b5dd58210e8b6942200a424bcccbb81ac884e41303479ab09f251a2a97addc2de61efdc9576c
languageName: node
linkType: hard

Expand Down