Skip to content

fix: lerna publish #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2022
Merged

fix: lerna publish #612

merged 2 commits into from
Jan 25, 2022

Conversation

@DorianMaliszewski
Copy link
Member

@DorianMaliszewski DorianMaliszewski commented Jan 25, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jan 25, 2022 •
edited
Loading

Codecov Report

Merging #612 (0908b54) into main (98c77f9) will not change coverage.
The diff coverage is n/a.

❗ Current head 0908b54 differs from pull request most recent head fc5c916. Consider uploading reports for the commit fc5c916 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##              main      #612   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          527       527           
  Branches        87        87           
=========================================
  Hits           527       527

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c77f9...fc5c916. Read the comment docs.

chambo-e
chambo-e reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@chambo-e chambo-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed ? 🤔

@DorianMaliszewski DorianMaliszewski self-assigned this Jan 25, 2022
@DorianMaliszewski DorianMaliszewski added the bug Something isn't working label Jan 25, 2022
@DorianMaliszewski
Copy link
Member Author

DorianMaliszewski commented Jan 25, 2022

Why is this needed ? 🤔

Needed because of : lerna/lerna#2788 (comment)

IK that npm whoami is working for automation token but it doesn't work anymore

@DorianMaliszewski DorianMaliszewski merged commit 8ab8459 into main Jan 25, 2022
@DorianMaliszewski DorianMaliszewski deleted the fix/lerna-publish branch January 25, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@chambo-e chambo-e chambo-e left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@DorianMaliszewski DorianMaliszewski

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DorianMaliszewski @chambo-e