refactor: drop isFirstLoad to use isLoading only #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianMaliszewski
force-pushed
the
refactor/replace-is-first-load
branch
from
fe5d561 to
dc18296
Compare
DorianMaliszewski
requested review from
QuiiBz,
adriengibrat,
matthprost and
vincentaudebert
DorianMaliszewski
force-pushed
the
refactor/replace-is-first-load
branch
from
dc18296 to
06eb5bc
Compare
Codecov Report
@@ Coverage Diff @@
## main #613 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 527 526 -1
Branches 87 87
=========================================
- Hits 527 526 -1
Continue to review full report at Codecov.
|
DorianMaliszewski
force-pushed
the
refactor/replace-is-first-load
branch
from
06eb5bc to
b271cfd
Compare
QuiiBz
approved these changes
Jan 26, 2022
matthprost
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop isFirstLoad which check if request is enabled and idle to handle the case when you mount the hook and despite of enabled but request still idle. This will be dropped when we will batch updates.
Put this condition in isLoading