Skip to content

Conversation

@chambo-e
Copy link
Contributor

This will allow to wait for consent before loading external

@chambo-e chambo-e requested a review from a team April 21, 2022 07:34
@chambo-e chambo-e self-assigned this Apr 21, 2022
@chambo-e chambo-e requested review from Lawndlwd and vincentaudebert and removed request for a team April 21, 2022 07:34
@chambo-e chambo-e changed the title feat: do not load snippets if settings not provided feat: do not load snippets if no settings provided Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #731 (a224ac2) into main (81726b3) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #731   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines          573       582    +9     
  Branches        86        88    +2     
=========================================
+ Hits           573       582    +9     
Impacted Files Coverage Δ
packages/use-gtm/src/useGTM.tsx 100.00% <100.00%> (ø)
packages/use-segment/src/useSegment.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81726b3...a224ac2. Read the comment docs.

@chambo-e chambo-e merged commit bfb0809 into main Apr 22, 2022
@chambo-e chambo-e deleted the feat/conditionnal_load branch April 22, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants