Skip to content

Conversation

@philibea
Copy link
Collaborator

No description provided.

@philibea philibea requested a review from chambo-e April 21, 2022 09:34
@philibea philibea self-assigned this Apr 21, 2022
@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #732 (3013016) into main (b208776) will not change coverage.
The diff coverage is n/a.

❗ Current head 3013016 differs from pull request most recent head 4bbe086. Consider uploading reports for the commit 4bbe086 to get more accurate results

@@            Coverage Diff            @@
##              main      #732   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        20    -1     
  Lines          556       582   +26     
  Branches        78        88   +10     
=========================================
+ Hits           556       582   +26     
Impacted Files Coverage Δ
packages/use-i18n/src/usei18n.tsx 100.00% <0.00%> (ø)
packages/use-dataloader/src/dataloader.ts 100.00% <0.00%> (ø)
packages/use-dataloader/src/useDataLoader.ts 100.00% <0.00%> (ø)
packages/use-dataloader/src/DataLoaderProvider.tsx 100.00% <0.00%> (ø)
...kages/use-dataloader/src/usePaginatedDataLoader.ts 100.00% <0.00%> (ø)
packages/use-media/src/useMedia.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b208776...4bbe086. Read the comment docs.

@philibea philibea requested review from a team and QuiiBz and removed request for a team May 2, 2022 15:38
@QuiiBz
Copy link
Contributor

QuiiBz commented May 3, 2022

Looks like node 18 handles Intl.DateTimeFormat differently compared to node 16/17

@philibea
Copy link
Collaborator Author

philibea commented May 4, 2022

Looks like node 18 handles Intl.DateTimeFormat differently compared to node 16/17

@QuiiBz yes it's not the first time we have this issue. We can ignore this actually

@chambo-e
Copy link
Contributor

chambo-e commented May 5, 2022

Looks like node 18 handles Intl.DateTimeFormat differently compared to node 16/17

@QuiiBz yes it's not the first time we have this issue. We can ignore this actually

@philibea behaviour is different in node 14,16,17 and 18, we need to find a way to handle this properly

@philibea philibea merged commit 18ccef6 into main Aug 1, 2022
@philibea philibea deleted the node-18-ci branch August 1, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants