Skip to content

Conversation

@philibea
Copy link
Collaborator

@philibea philibea commented Mar 11, 2021

Migration of tiny hooks useQueryParams
What i did :

  • add unit test
  • avoid useless re-render

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #74 (840be4e) into master (dc04b39) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         3    +1     
  Lines           29        52   +23     
  Branches         2         6    +4     
=========================================
+ Hits            29        52   +23     
Impacted Files Coverage Δ
packages/use-query-params/src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc04b39...840be4e. Read the comment docs.

@chambo-e
Copy link
Contributor

You'll also need to update the main README to add the reference to this package :)

@philibea philibea force-pushed the add-hooks-use-query-params branch 2 times, most recently from 3990884 to 40c213f Compare March 11, 2021 17:23
@philibea philibea requested review from chambo-e and matthprost March 11, 2021 17:24
@philibea philibea force-pushed the add-hooks-use-query-params branch 8 times, most recently from 7f8f630 to 4b903df Compare March 12, 2021 10:29
@philibea philibea added hooks hooks react react labels Mar 12, 2021
@philibea philibea self-assigned this Mar 12, 2021
@philibea philibea marked this pull request as ready for review March 12, 2021 10:33
@philibea philibea force-pushed the add-hooks-use-query-params branch from 4b903df to 9f1e98b Compare March 12, 2021 11:18
@philibea philibea force-pushed the add-hooks-use-query-params branch 2 times, most recently from 2baa766 to d81f7c5 Compare March 12, 2021 14:57
@philibea philibea force-pushed the add-hooks-use-query-params branch 2 times, most recently from 5f2332b to 9e27b55 Compare March 12, 2021 15:24
@philibea philibea force-pushed the add-hooks-use-query-params branch 4 times, most recently from 50b0827 to 97c51c1 Compare March 12, 2021 15:30
@philibea philibea force-pushed the add-hooks-use-query-params branch from 97c51c1 to 133f915 Compare March 12, 2021 15:34
@philibea philibea force-pushed the add-hooks-use-query-params branch from 133f915 to 840be4e Compare March 12, 2021 15:35
@philibea philibea merged commit 72935e2 into master Mar 12, 2021
@philibea philibea deleted the add-hooks-use-query-params branch March 12, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hooks hooks react react

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants