Skip to content

chore: use @testing-library/react for renderHook #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2022
Merged

chore: use @testing-library/react for renderHook #828

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
88c146e
chore: use for
Jun 6, 2022
45c8ae1
fix: update lockfile
Jun 6, 2022
0daa775
fix: react throw errors
Jun 9, 2022
36e24d4
Merge branch 'main' into chore/testing-lib-render-hook
Jun 9, 2022
539cd89
fix: useMedia
Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
"@rollup/plugin-node-resolve": "13.3.0",
"@testing-library/jest-dom": "5.16.4",
"@testing-library/react": "13.3.0",
"@testing-library/react-hooks": "8.0.0",
"@types/jest": "28.1.1",
"@types/node": "17.0.31",
"@types/prop-types": "15.7.5",
Expand Down
19 changes: 13 additions & 6 deletions packages/use-gtm/src/__tests__/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { fireEvent } from '@testing-library/react'
import { renderHook } from '@testing-library/react-hooks'
import { fireEvent, renderHook } from '@testing-library/react'
import mockdate from 'mockdate'
import { ReactNode } from 'react'
import GTMProvider, { SendGTM, useGTM } from '..'
Expand Down Expand Up @@ -48,10 +47,18 @@ describe('GTM hook', () => {
})

it('useGTM should not be defined without GTMProvider', () => {
const { result } = renderHook(() => useGTM())
expect(() => {
expect(result.current).toBe(undefined)
}).toThrow(Error('useGTM must be used within a GTMProvider'))
const orignalConsoleError = console.error
console.error = jest.fn

try {
renderHook(() => useGTM())
} catch (error) {
expect((error as Error)?.message).toBe(
'useGTM must be used within a GTMProvider',
)
}

console.error = orignalConsoleError
})

it('Provider should call onLoadError if script fail to load', () => {
Expand Down
Loading