fix: optimistic isloading value on hook mount #831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuiiBz
approved these changes
Jun 7, 2022
DorianMaliszewski
force-pushed
the
feat/should-reset-is-loading-directly-on-mount
branch
from
75272ae to
8928ab6
Compare
matthprost
approved these changes
Jun 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #831 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 551 556 +5
Branches 77 78 +1
=========================================
+ Hits 551 556 +5
Continue to review full report at Codecov.
|
DorianMaliszewski
deleted the
feat/should-reset-is-loading-directly-on-mount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isLoading need to be true on mount same key but need reload