Skip to content

feat: remove boot type #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 5, 2019
Merged

feat: remove boot type #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d302b3c
feat: update generated apis
scaleway-bot Sep 5, 2019
4da4eec
fix tests
kindermoumoute Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions api/instance/v1/instance_sdk.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1445,10 +1445,6 @@ type CreateServerRequest struct {
EnableIPv6 bool `json:"enable_ipv6,omitempty"`
// PublicIP define the public IPv4 attached to the server
PublicIP string `json:"public_ip,omitempty"`
// BootType define the boot type you want to use
//
// Default value: local
BootType ServerBootType `json:"boot_type"`
// Organization define the server organization
Organization string `json:"organization,omitempty"`
// Tags define the server tags
Expand Down Expand Up @@ -1690,10 +1686,6 @@ type updateServerRequest struct {
ServerID string `json:"-"`

Name *string `json:"name,omitempty"`
// BootType
//
// Default value: local
BootType ServerBootType `json:"boot_type"`

Tags *[]string `json:"tags,omitempty"`

Expand Down
1 change: 0 additions & 1 deletion api/instance/v1/instance_sdk_server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ func TestServerUpdate(t *testing.T) {
Organization: organization,
Image: image,
EnableIPv6: enableIPv6,
BootType: bootType,
CommercialType: commercialType,
Tags: tags,
DynamicIPRequired: dynamicIPRequired,
Expand Down
2 changes: 0 additions & 2 deletions api/instance/v1/server_utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ func TestAPI_ServerUserData(t *testing.T) {
Zone: scw.ZoneFrPar1,
CommercialType: "DEV1-S",
Name: namegenerator.GetRandomName("srv"),
BootType: ServerBootTypeLocal,
Image: "f974feac-abae-4365-b988-8ec7d1cec10d",
Organization: "14d2f7ae-9775-414c-9bed-6810e060d500",
})
Expand Down Expand Up @@ -89,7 +88,6 @@ func TestAPI_AllServerUserData(t *testing.T) {
Zone: scw.ZoneFrPar1,
CommercialType: "DEV1-S",
Name: namegenerator.GetRandomName("srv"),
BootType: ServerBootTypeLocal,
Image: "f974feac-abae-4365-b988-8ec7d1cec10d",
Organization: "14d2f7ae-9775-414c-9bed-6810e060d500",
})
Expand Down
2 changes: 1 addition & 1 deletion api/instance/v1/testdata/all-server-user-data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
version: 1
interactions:
- request:
body: '{"name":"srv-hardcore-raman","commercial_type":"DEV1-S","image":"f974feac-abae-4365-b988-8ec7d1cec10d","boot_type":"local","organization":"14d2f7ae-9775-414c-9bed-6810e060d500"}'
body: '{"name":"srv-hardcore-raman","commercial_type":"DEV1-S","image":"f974feac-abae-4365-b988-8ec7d1cec10d","organization":"14d2f7ae-9775-414c-9bed-6810e060d500"}'
form: {}
headers:
Content-Type:
Expand Down
2 changes: 1 addition & 1 deletion api/instance/v1/testdata/server-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
version: 1
interactions:
- request:
body: '{"name":"instance_sdk_server_test","dynamic_ip_required":true,"commercial_type":"START1-S","image":"f974feac-abae-4365-b988-8ec7d1cec10d","enable_ipv6":true,"boot_type":"local","organization":"d429f6a1-c0a6-48cf-8b5a-1f9dfe76ffd3","tags":["foo","bar"]}'
body: '{"name":"instance_sdk_server_test","dynamic_ip_required":true,"commercial_type":"START1-S","image":"f974feac-abae-4365-b988-8ec7d1cec10d","enable_ipv6":true,"organization":"d429f6a1-c0a6-48cf-8b5a-1f9dfe76ffd3","tags":["foo","bar"]}'
form: {}
headers:
Content-Type:
Expand Down
2 changes: 1 addition & 1 deletion api/instance/v1/testdata/server-user-data.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
version: 1
interactions:
- request:
body: '{"name":"srv-wonderful-goldberg","commercial_type":"DEV1-S","image":"f974feac-abae-4365-b988-8ec7d1cec10d","boot_type":"local","organization":"14d2f7ae-9775-414c-9bed-6810e060d500"}'
body: '{"name":"srv-wonderful-goldberg","commercial_type":"DEV1-S","image":"f974feac-abae-4365-b988-8ec7d1cec10d","organization":"14d2f7ae-9775-414c-9bed-6810e060d500"}'
form: {}
headers:
Content-Type:
Expand Down