Skip to content

Conversation

@Vinzius
Copy link
Contributor

@Vinzius Vinzius commented Nov 20, 2023

No description provided.

@Vinzius Vinzius marked this pull request as ready for review November 20, 2023 08:56
@Vinzius Vinzius requested a review from Codelax November 20, 2023 09:20
@Vinzius Vinzius changed the title feat(instance): replace some update utils by generated routes feat(instance): replace some get/put utils by patch ones Nov 20, 2023
@philibea
Copy link
Contributor

philibea commented Nov 20, 2023

@Vinzius @Codelax Should we deprecated the usage of PUT request into the sdk ?

@Vinzius Vinzius marked this pull request as draft November 20, 2023 10:37
@Vinzius Vinzius force-pushed the feat/instance-new-updates branch from b9c5636 to 9414f2f Compare December 4, 2023 09:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e1a919) 100.00% compared to head (9414f2f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1010   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           45        45           
  Lines          683       683           
  Branches       133       133           
=========================================
  Hits           683       683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vinzius Vinzius marked this pull request as ready for review December 4, 2023 10:09
@Vinzius Vinzius added this pull request to the merge queue Dec 4, 2023
Merged via the queue into main with commit b67133c Dec 4, 2023
@Vinzius Vinzius deleted the feat/instance-new-updates branch December 4, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants