Skip to content

feat(k8s): use structs for node taints #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2023
Merged

feat(k8s): use structs for node taints #1076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/clients/src/api/k8s/v1/index.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ export type {
DeleteNodeRequest,
DeletePoolRequest,
ExternalNode,
ExternalNodeCoreV1Taint,
GetClusterKubeConfigRequest,
GetClusterRequest,
GetNodeRequest,
Expand Down
21 changes: 21 additions & 0 deletions packages/clients/src/api/k8s/v1/marshalling.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import type {
CreatePoolRequest,
CreatePoolRequestUpgradePolicy,
ExternalNode,
ExternalNodeCoreV1Taint,
ListClusterAvailableTypesResponse,
ListClusterAvailableVersionsResponse,
ListClusterTypesResponse,
Expand Down Expand Up @@ -256,6 +257,22 @@ export const unmarshalNode = (data: unknown): Node => {
} as Node
}

const unmarshalExternalNodeCoreV1Taint = (
data: unknown,
): ExternalNodeCoreV1Taint => {
if (!isJSONObject(data)) {
throw new TypeError(
`Unmarshalling the type 'ExternalNodeCoreV1Taint' failed as data isn't a dictionary.`,
)
}

return {
effect: data.effect,
key: data.key,
value: data.value,
} as ExternalNodeCoreV1Taint
}

export const unmarshalExternalNode = (data: unknown): ExternalNode => {
if (!isJSONObject(data)) {
throw new TypeError(
Expand All @@ -274,6 +291,10 @@ export const unmarshalExternalNode = (data: unknown): ExternalNode => {
kubeletConfig: data.kubelet_config,
name: data.name,
nodeLabels: data.node_labels,
nodeTaints: unmarshalArrayOfObject(
data.node_taints,
unmarshalExternalNodeCoreV1Taint,
),
poolVersion: data.pool_version,
runcVersion: data.runc_version,
} as ExternalNode
Expand Down
7 changes: 7 additions & 0 deletions packages/clients/src/api/k8s/v1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,12 @@ export interface CreatePoolRequestUpgradePolicy {
maxSurge?: number
}

export interface ExternalNodeCoreV1Taint {
key: string
value: string
effect: string
}

export interface ClusterType {
/** Cluster type name. */
name: string
Expand Down Expand Up @@ -891,6 +897,7 @@ export interface ExternalNode {
runcVersion: string
cniPluginsVersion: string
nodeLabels: Record<string, string>
nodeTaints: ExternalNodeCoreV1Taint[]
}

export type GetClusterKubeConfigRequest = {
Expand Down