Skip to content

feat(secret_manager): return type on AccessSecretVersion #1214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024
Merged

feat(secret_manager): return type on AccessSecretVersion #1214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/clients/src/api/secret/v1beta1/marshalling.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export const unmarshalAccessSecretVersionResponse = (
dataCrc32: data.data_crc32,
revision: data.revision,
secretId: data.secret_id,
type: data.type,
} as AccessSecretVersionResponse
}

Expand Down
6 changes: 4 additions & 2 deletions packages/clients/src/api/secret/v1beta1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export interface Secret {
managed: boolean
/** Returns `true` for protected secrets that cannot be deleted. */
protected: boolean
/** See `Secret.Type` enum for description of values. */
/** See the `Secret.Type` enum for a description of values. */
type: SecretType
/** Location of the secret in the directory structure. */
path: string
Expand Down Expand Up @@ -188,6 +188,8 @@ export interface AccessSecretVersionResponse {
* the version.
*/
dataCrc32?: number
/** See the `Secret.Type` enum for a description of values. */
type: SecretType
}

export type AddSecretOwnerRequest = {
Expand Down Expand Up @@ -243,7 +245,7 @@ export type CreateSecretRequest = {
/** Description of the secret. */
description?: string
/**
* (Optional.) See `Secret.Type` enum for description of values. If not
* (Optional.) See the `Secret.Type` enum for a description of values. If not
* specified, the type is `Opaque`.
*/
type?: SecretType
Expand Down