Skip to content

feat(container): remove JWT in favor of CreateToken #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged

feat(container): remove JWT in favor of CreateToken #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86989a5
feat: update generated APIs
scaleway-bot Aug 29, 2024
e15cfa0
Merge branch 'main' into v1.5359.0
remyleone Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions packages/clients/src/api/container/v1beta1/api.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ import type {
GetNamespaceRequest,
GetTokenRequest,
GetTriggerRequest,
IssueJWTRequest,
ListContainersRequest,
ListContainersResponse,
ListCronsRequest,
Expand Down Expand Up @@ -570,31 +569,6 @@ export class API extends ParentAPI {
unmarshalDomain,
)

/**
* Create a JWT token. Deprecated in favor of CreateToken.
*
* @deprecated
* @param request - The request {@link IssueJWTRequest}
* @returns A Promise of Token
*/
issueJWT = (request: Readonly<IssueJWTRequest> = {}) =>
this.client.fetch<Token>(
{
method: 'GET',
path: `/containers/v1beta1/regions/${validatePathParam('region', request.region ?? this.client.settings.defaultRegion)}/issue-jwt`,
urlParams: urlParams(
['expires_at', request.expiresAt],
...Object.entries(
resolveOneOf([
{ param: 'container_id', value: request.containerId },
{ param: 'namespace_id', value: request.namespaceId },
]),
),
),
},
unmarshalToken,
)

/**
* Create a new revocable token.
*
Expand Down
1 change: 0 additions & 1 deletion packages/clients/src/api/container/v1beta1/index.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export type {
GetNamespaceRequest,
GetTokenRequest,
GetTriggerRequest,
IssueJWTRequest,
ListContainersRequest,
ListContainersRequestOrderBy,
ListContainersResponse,
Expand Down
13 changes: 0 additions & 13 deletions packages/clients/src/api/container/v1beta1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,19 +642,6 @@ export type GetTriggerRequest = {
triggerId: string
}

export type IssueJWTRequest = {
/**
* Region to target. If none is passed will use default region from the
* config.
*/
region?: Region
/** One-of ('scope'): at most one of 'containerId', 'namespaceId' could be set. */
containerId?: string
/** One-of ('scope'): at most one of 'containerId', 'namespaceId' could be set. */
namespaceId?: string
expiresAt?: Date
}

export type ListContainersRequest = {
/**
* Region to target. If none is passed will use default region from the
Expand Down
26 changes: 0 additions & 26 deletions packages/clients/src/api/function/v1beta1/api.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ import type {
GetNamespaceRequest,
GetTokenRequest,
GetTriggerRequest,
IssueJWTRequest,
ListCronsRequest,
ListCronsResponse,
ListDomainsRequest,
Expand Down Expand Up @@ -633,31 +632,6 @@ export class API extends ParentAPI {
unmarshalDomain,
)

/**
* Create a JWT token. Deprecated in favor of CreateToken.
*
* @deprecated
* @param request - The request {@link IssueJWTRequest}
* @returns A Promise of Token
*/
issueJWT = (request: Readonly<IssueJWTRequest> = {}) =>
this.client.fetch<Token>(
{
method: 'GET',
path: `/functions/v1beta1/regions/${validatePathParam('region', request.region ?? this.client.settings.defaultRegion)}/issue-jwt`,
urlParams: urlParams(
['expires_at', request.expiresAt],
...Object.entries(
resolveOneOf([
{ param: 'function_id', value: request.functionId },
{ param: 'namespace_id', value: request.namespaceId },
]),
),
),
},
unmarshalToken,
)

/**
* Create a new revocable token.
*
Expand Down
1 change: 0 additions & 1 deletion packages/clients/src/api/function/v1beta1/index.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ export type {
GetNamespaceRequest,
GetTokenRequest,
GetTriggerRequest,
IssueJWTRequest,
ListCronsRequest,
ListCronsRequestOrderBy,
ListCronsResponse,
Expand Down
13 changes: 0 additions & 13 deletions packages/clients/src/api/function/v1beta1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -701,19 +701,6 @@ export type GetTriggerRequest = {
triggerId: string
}

export type IssueJWTRequest = {
/**
* Region to target. If none is passed will use default region from the
* config.
*/
region?: Region
/** One-of ('scope'): at most one of 'functionId', 'namespaceId' could be set. */
functionId?: string
/** One-of ('scope'): at most one of 'functionId', 'namespaceId' could be set. */
namespaceId?: string
expiresAt?: Date
}

export type ListCronsRequest = {
/**
* Region to target. If none is passed will use default region from the
Expand Down