Skip to content

Conversation

@dehy
Copy link
Contributor

@dehy dehy commented Feb 6, 2025

The createClient() method is using Partial<Settings> type, extending DefaultValues that was using ProfileDefaultValues type. This last type lacked the accessKey and secretKey properties.

DefaultValues type is now inheriting Profile type, which contains the correct properties.

fixes #1752

@dehy dehy requested a review from remyleone as a code owner February 6, 2025 11:09
@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 2cb5ea3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dehy dehy changed the title fix unknown property accessKey in createClient fix(types): unknown property accessKey in createClient Feb 6, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.01%. Comparing base (c80a70f) to head (2cb5ea3).
Report is 478 commits behind head on main.

Files with missing lines Patch % Lines
packages/clients/src/scw/__tests__/api.test.ts 66.66% 2 Missing ⚠️
...ients/src/scw/__tests__/client-ini-factory.test.ts 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
- Coverage   94.01%   93.01%   -1.00%     
==========================================
  Files          53       92      +39     
  Lines        3427     4985    +1558     
  Branches      476      962     +486     
==========================================
+ Hits         3222     4637    +1415     
- Misses        205      348     +143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 added this pull request to the merge queue Feb 12, 2025
Merged via the queue into scaleway:main with commit 865b8c7 Feb 12, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid createClient signature type

3 participants