Skip to content

chore(linter): disable deprecation warnings for APIs #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022
Merged

chore(linter): disable deprecation warnings for APIs #214

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/clients/src/api/.eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "defaults|request" }],
"max-classes-per-file": "off",
"tsdoc/syntax": "off",
"no-underscore-dangle": ["error", { "allowAfterThis": true }]
"no-underscore-dangle": ["error", { "allowAfterThis": true }],
"deprecation/deprecation": "off"
}
}
2 changes: 1 addition & 1 deletion packages/clients/src/scw/client-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export const assertValidSettings = (obj: Readonly<Settings>): void => {
// API URL.
if (!isURL(obj.apiURL)) throw new Error(`Invalid URL ${obj.apiURL}`)

if (obj.apiURL.substr(-1) === '/')
if (obj.apiURL.slice(-1) === '/')
throw new Error(
`Invalid URL ${obj.apiURL}: it should not have a trailing slash`,
)
Expand Down