Skip to content

fix(instance): remove NullableStringValue type #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix(instance): remove NullableStringValue type #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 3 additions & 18 deletions packages/clients/src/api/instance/v1/marshalling.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ import type {
ListSnapshotsResponse,
ListVolumesResponse,
ListVolumesTypesResponse,
NullableStringValue,
PlacementGroup,
PlacementGroupServer,
PrivateNIC,
Expand Down Expand Up @@ -1462,14 +1461,6 @@ const marshalImage = (
zone: request.zone,
})

const marshalNullableStringValue = (
request: NullableStringValue,
defaults: DefaultValues,
): Record<string, unknown> => ({
null: request.null,
value: request.value,
})

const marshalPlacementGroup = (
request: PlacementGroup,
defaults: DefaultValues,
Expand Down Expand Up @@ -2046,12 +2037,8 @@ export const marshalUpdateIpRequest = (
request: UpdateIpRequest,
defaults: DefaultValues,
): Record<string, unknown> => ({
reverse: request.reverse
? marshalNullableStringValue(request.reverse, defaults)
: undefined,
server: request.server
? marshalNullableStringValue(request.server, defaults)
: undefined,
reverse: request.reverse,
server: request.server,
tags: request.tags,
})

Expand Down Expand Up @@ -2081,9 +2068,7 @@ export const marshalUpdateServerRequest = (
dynamic_ip_required: request.dynamicIpRequired,
enable_ipv6: request.enableIpv6,
name: request.name,
placement_group: request.placementGroup
? marshalNullableStringValue(request.placementGroup, defaults)
: undefined,
placement_group: request.placementGroup,
private_nics: request.privateNics
? request.privateNics.map(elt => marshalPrivateNIC(elt, defaults))
: undefined,
Expand Down
9 changes: 2 additions & 7 deletions packages/clients/src/api/instance/v1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,11 +364,6 @@ export interface ListVolumesTypesResponse {
volumes: Record<string, VolumeType>
}

export interface NullableStringValue {
null: boolean
value: string
}

/** Placement group */
export interface PlacementGroup {
/** The placement group unique ID */
Expand Down Expand Up @@ -1571,10 +1566,10 @@ export type UpdateIpRequest = {
/** IP ID or IP address */
ip: string
/** Reverse domain name */
reverse?: NullableStringValue
reverse?: string
/** An array of keywords you want to tag this IP with */
tags?: Array<string>
server?: NullableStringValue
server?: string
}

export type DeleteIpRequest = {
Expand Down
3 changes: 1 addition & 2 deletions packages/clients/src/api/instance/v1/types.private.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import type {
Bootscript,
Image,
ImageState,
NullableStringValue,
PlacementGroup,
PrivateNIC,
SecurityGroup,
Expand Down Expand Up @@ -180,7 +179,7 @@ export type UpdateServerRequest = {
protected?: boolean
securityGroup?: SecurityGroupTemplate
/** Placement group ID if server must be part of a placement group */
placementGroup?: NullableStringValue
placementGroup?: string
/** The server private NICs */
privateNics?: Array<PrivateNIC>
}
Expand Down