Skip to content

feat: update to Node18, remove cross-fetch, and run tests on node+jsdom #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 25, 2023
Merged

feat: update to Node18, remove cross-fetch, and run tests on node+jsdom #386

merged 8 commits into from
Jan 25, 2023

Conversation

@Vinzius
Copy link
Contributor

@Vinzius Vinzius commented Jan 19, 2023 •
edited
Loading

  • Remove cross-fetch
  • Run tests Browser && Node

@Vinzius
feat: first draft to remove cross-fetch
0bf8a93 
feat: try adding undici types

feat: include dom lib

docs: mention build outputs
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023 •
edited
Loading

Codecov Report

Merging #386 (210cef1) into main (c45a5d8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #386   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines          636       636           
  Branches       129       129           
=========================================
  Hits           636       636

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Vinzius Vinzius changed the title Draft: feat: update to Node18, remove cross-fetch and publish as ESM only feat: update to Node18, remove cross-fetch, and run tests on node+jsdom Jan 25, 2023
@Vinzius Vinzius changed the title feat: update to Node18, remove cross-fetch, and run tests on node+jsdom Draft: feat: update to Node18, remove cross-fetch, and run tests on node+jsdom Jan 25, 2023
@Vinzius Vinzius changed the title Draft: feat: update to Node18, remove cross-fetch, and run tests on node+jsdom feat: update to Node18, remove cross-fetch, and run tests on node+jsdom Jan 25, 2023
@Vinzius Vinzius merged commit 4e1fe02 into main Jan 25, 2023
@Vinzius Vinzius deleted the feat/node18 branch January 25, 2023 10:26
@Vinzius Vinzius linked an issue Jan 25, 2023 that may be closed by this pull request
Upgrade to Node 18 and drop cross-fetch #308
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@quantumsheep quantumsheep quantumsheep approved these changes

+1 more reviewer

@QuiiBz QuiiBz QuiiBz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Upgrade to Node 18 and drop cross-fetch

5 participants

@Vinzius @codecov-commenter @quantumsheep @QuiiBz