Skip to content

chore: fix a few typos #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022
Merged

chore: fix a few typos #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa3ddf8
chore: fix some typos
Vinzius Aug 4, 2022
34ac8b6
chore(examples): set non-specific beta version
Vinzius Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions examples/nodejs-minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"start": "node ./dist/index"
},
"dependencies": {
"@scaleway/configuration-loader": "^0.1.0-beta.2",
"@scaleway/sdk": "^0.1.0-alpha"
"@scaleway/configuration-loader": "^0.1.0-beta",
"@scaleway/sdk": "^0.1.0-beta"
},
"devDependencies": {
"@types/node": "^17.0.45",
Expand Down
4 changes: 2 additions & 2 deletions examples/serverless-function-minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
"author": "",
"license": "ISC",
"dependencies": {
"@scaleway/configuration-loader": "^0.1.0-beta.2",
"@scaleway/sdk": "^0.1.0-alpha"
"@scaleway/configuration-loader": "^0.1.0-beta",
"@scaleway/sdk": "^0.1.0-beta"
},
"devDependencies": {
"serverless-scaleway-functions": "^0.4.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/clients/src/scw/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Client } from './client'

/**
* Abstract class to instanciate API from a {@link Client}.
* Abstract class to instantiate API from a {@link Client}.
*
* @internal
*/
Expand Down
10 changes: 5 additions & 5 deletions packages/clients/src/scw/client-ini-factory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { Settings } from './client-settings'
export type ClientConfig = (obj: Settings) => Settings

/**
* Instanciates the SDK from a configuration {@link Profile}.
* Instantiates the SDK from a configuration {@link Profile}.
*
* @param profile - The profile
* @returns A factory {@link ClientConfig}
Expand Down Expand Up @@ -41,7 +41,7 @@ export const withProfile =
}

/**
* Instanciates the SDK with a different HTTP client.
* Instantiates the SDK with a different HTTP client.
*
* @param httpClient - A fetch compatible HTTP client
* @returns A factory {@link ClientConfig}
Expand All @@ -55,7 +55,7 @@ export const withHTTPClient =
(settings: Readonly<Settings>): Settings => ({ ...settings, httpClient })

/**
* Instanciates the SDK with a default page size.
* Instantiates the SDK with a default page size.
*
* @param defaultPageSize - The default page size
* @returns A factory {@link ClientConfig}
Expand All @@ -69,7 +69,7 @@ export const withDefaultPageSize =
(settings: Readonly<Settings>): Settings => ({ ...settings, defaultPageSize })

/**
* Instanciates the SDK with a different default user agent.
* Instantiates the SDK with a different default user agent.
*
* @param userAgent - The default user agent
* @returns A factory {@link ClientConfig}
Expand All @@ -83,7 +83,7 @@ export const withUserAgent =
(settings: Readonly<Settings>): Settings => ({ ...settings, userAgent })

/**
* Instanciates the SDK with an additional user agent.
* Instantiates the SDK with an additional user agent.
*
* @param userAgent - The suffix to append to default user agent
* @returns A factory {@link ClientConfig}
Expand Down
2 changes: 1 addition & 1 deletion packages/configuration-loader/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const profile = {
}
```

And then use this profile to instanciate the SDK client with `const client = createClient(profile)`.
And then use this profile to instantiate the SDK client with `const client = createClient(profile)`.

However, you might prefer to store these variables in either a configuration file (e.g. local testing) or environment variables (e.g. serverless).

Expand Down