Skip to content

chore: avoid deprecation warning #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2023
Merged

chore: avoid deprecation warning #662

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/clients/src/scw/__tests__/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,11 @@ describe('authenticateWithSessionToken', () => {
it('retrieves the token and updates the request header', async () => {
const dummyToken = 'dummy'
const sourceReq = new Request('https://api.scaleway.com/my/path')
/* eslint-disable deprecation/deprecation */
const updatedReq = await authenticateWithSessionToken(
(): Promise<string> => Promise.resolve(dummyToken),
)({ request: sourceReq })
/* eslint-enable deprecation/deprecation */
const expectedReq = sourceReq.clone()
expectedReq.headers.append('x-session-token', 'dummy')
expect(updatedReq).toStrictEqual(expectedReq)
Expand Down
6 changes: 5 additions & 1 deletion packages/clients/src/scw/custom-marshalling.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,11 @@ import type {
TimeSeriesPoint,
} from './custom-types'

/** Unmarshals {@link Money} */
/**
* Unmarshals {@link Money}
*
* @internal
*/
export const unmarshalMoney = (data: unknown) => {
if (!isJSONObject(data)) {
throw new TypeError(
Expand Down
2 changes: 2 additions & 0 deletions packages/clients/src/scw/fetch/resource-paginator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,8 @@ export const fetchAll = async <
* @param fetcher - The method to retrieve paginated resources
* @param request - A request with pagination options
* @returns A resource Promise with the pagination helpers
*
* @internal
*/
export const enrichForPagination = <
K extends string,
Expand Down