Skip to content

feat(secret): add projectId field in requests #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023
Merged

feat(secret): add projectId field in requests #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions packages/clients/src/api/secret/v1alpha1/api.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class API extends ParentAPI {

/**
* Get metadata using the secret's ID. Retrieve the metadata of a secret
* specified by the `region` and the `secret_id` parameters.
* specified by the `region`, `secret_id` and `project_id` parameters.
*
* @param request - The request {@link GetSecretByNameRequest}
* @returns A Promise of Secret
Expand All @@ -120,6 +120,7 @@ export class API extends ParentAPI {
'secretName',
request.secretName,
)}`,
urlParams: urlParams(['project_id', request.projectId]),
},
unmarshalSecret,
)
Expand Down Expand Up @@ -293,7 +294,7 @@ export class API extends ParentAPI {
/**
* Get metadata of a secret's version using the secret's name. Retrieve the
* metadata of a secret's given version specified by the `region`,
* `secret_name` and `revision` parameters.
* `secret_name`, `revision` and `project_id` parameters.
*
* @param request - The request {@link GetSecretVersionByNameRequest}
* @returns A Promise of SecretVersion
Expand All @@ -309,6 +310,7 @@ export class API extends ParentAPI {
'secretName',
request.secretName,
)}/versions/${validatePathParam('revision', request.revision)}`,
urlParams: urlParams(['project_id', request.projectId]),
},
unmarshalSecretVersion,
)
Expand Down Expand Up @@ -391,6 +393,7 @@ export class API extends ParentAPI {
'page_size',
request.pageSize ?? this.client.settings.defaultPageSize,
],
['project_id', request.projectId],
['status', request.status],
),
},
Expand All @@ -399,8 +402,8 @@ export class API extends ParentAPI {

/**
* List versions of a secret using the secret's name. Retrieve the list of a
* given secret's versions specified by the `secret_name` and `region`
* parameters.
* given secret's versions specified by the `secret_name`,`region` and
* `project_id` parameters.
*
* @param request - The request {@link ListSecretVersionsByNameRequest}
* @returns A Promise of ListSecretVersionsResponse
Expand Down Expand Up @@ -487,8 +490,8 @@ export class API extends ParentAPI {

/**
* Access a secret's version using the secret's name. Access sensitive data in
* a secret's version specified by the `region`, `secret_name` and `revision`
* parameters.
* a secret's version specified by the `region`, `secret_name`, `revision` and
* `project_id` parameters.
*
* @param request - The request {@link AccessSecretVersionByNameRequest}
* @returns A Promise of AccessSecretVersionResponse
Expand All @@ -506,6 +509,7 @@ export class API extends ParentAPI {
'secretName',
request.secretName,
)}/versions/${validatePathParam('revision', request.revision)}/access`,
urlParams: urlParams(['project_id', request.projectId]),
},
unmarshalAccessSecretVersionResponse,
)
Expand Down
22 changes: 21 additions & 1 deletion packages/clients/src/api/secret/v1alpha1/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ export type GetSecretByNameRequest = {
region?: Region
/** Name of the secret. */
secretName: string
/**
* ID of the Project to target. (Optional.) If not specified, Secret Manager
* will look for the secret in all Projects.
*/
projectId?: string
}

export type UpdateSecretRequest = {
Expand Down Expand Up @@ -229,7 +234,7 @@ export type CreateSecretVersionRequest = {
/** Description of the version. */
description?: string
/**
* Disable the previous secret version. Optional. If there is no previous
* Disable the previous secret version. (Optional.) If there is no previous
* version or if the previous version was already disabled, does nothing.
*/
disablePrevious?: boolean
Expand Down Expand Up @@ -308,6 +313,11 @@ export type GetSecretVersionByNameRequest = {
* subsequent revisions augment by 1. Value can be a number or "latest".
*/
revision: string
/**
* ID of the Project to target. (Optional.) If not specified, Secret Manager
* will look for the secret version in all Projects.
*/
projectId?: string
}

export type UpdateSecretVersionRequest = {
Expand Down Expand Up @@ -353,6 +363,11 @@ export type ListSecretVersionsByNameRequest = {
pageSize?: number
/** Filter results by status. */
status?: SecretVersionStatus[]
/**
* ID of the Project to target. (Optional.) If not specified, Secret Manager
* will look for the secret in all Projects.
*/
projectId?: string
}

export type EnableSecretVersionRequest = {
Expand Down Expand Up @@ -413,6 +428,11 @@ export type AccessSecretVersionByNameRequest = {
* subsequent revisions augment by 1. Value can be a number or "latest".
*/
revision: string
/**
* ID of the Project to target. (Optional.) If not specified, Secret Manager
* will look for the secret version in all Projects.
*/
projectId?: string
}

export type DestroySecretVersionRequest = {
Expand Down