ensure registry image priority is serverless framework #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etween console and serverless framework image
Shillaker
previously requested changes
Sep 23, 2022
Contributor
Shillaker
left a comment
Shillaker
left a comment
There was a problem hiding this comment.
Please tidy up the name of the PR and the description.
Is this covered by an integration test? If not, can we add one?
norbjd
reviewed
Sep 25, 2022
thomas-tacquet
changed the title
norbjd
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assigning to a container an image from an other source (for example the console) it will not be updated on
serverless deploycommandSo I added in updating parameter the registry image to ensure it's the one pushed by serverless framework.
Closes #111