Read credentials from scw config
#83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Shillaker
requested review from
RamyChaabane and
thomas-tacquet
and removed request for
RamyChaabane
thomas-tacquet
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us read credentials from the Scaleway CLI configuration file (found at
~/.config/scw/config.yml) if it exists.This makes it easier to configure functions if you've already got the CLI set up, as you no longer need to set environment variables, or copy-paste tokens into your
serverless.yml. This also simplifies the "quick start" for the project.The
scwconfig file takes lowest precedence, therefore if someone has specified environment variables, options, or added config in theirserverless.ymlfile, it will use that instead.I've also added a test for reading the credentials with the correct precedence.