Support serverless invoke
#86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shillaker
commented
Jun 23, 2022
|
I would love this one to land, thanks for the effort you put into it! |
Shillaker
commented
Jun 28, 2022
Shillaker
commented
Jun 28, 2022
thomas-tacquet
approved these changes
Jun 28, 2022
Shillaker
commented
Jun 28, 2022
invoke/scalewayInvoke.js
Outdated
| api, | ||
| ); | ||
|
|
||
| // Interrogate config to see if we're invoking a container or a function |
Contributor
Author
There was a problem hiding this comment.
@RamyChaabane as discussed offline, I'll add a validation step before this, to throw an error if the function name is not mentioned at all in the serverless config file.
Shillaker
requested review from
RamyChaabane and
thomas-tacquet
and removed request for
RamyChaabane
invoke/scalewayInvoke.js
Outdated
| function validateFunction() { | ||
| // Here we check that the function is both specified, and defined as either a function or container | ||
| if(!this.options.function) { | ||
| const msg = 'Function not specified'; |
Contributor
There was a problem hiding this comment.
Function or Container not specfied
invoke/scalewayInvoke.js
Outdated
| this.isFunction = this.isDefinedFunction(this.options.function); | ||
|
|
||
| if(!this.isContainer && !this.isFunction) { | ||
| const msg = `Function ${this.options.function} not defined in servleress.yml`; |
Contributor
There was a problem hiding this comment.
Function or Container
invoke/scalewayInvoke.js
Outdated
| } | ||
| } | ||
|
|
||
| function lookUpFunction(ns) { |
Contributor
There was a problem hiding this comment.
lookUpFunctionOrContainer(ns)
invoke/scalewayInvoke.js
Outdated
| this.isContainer = false; | ||
| this.isFunction = false; | ||
|
|
||
| function validateFunction() { |
Contributor
There was a problem hiding this comment.
validateFunctionOrContainer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
serverless invokecommand, similar to AWS example.Changes:
invokeand update tests to useinvokerather than hitting HTTP endpoints.teststoshared, and add tests.