Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Sep 6, 2022

  • add doc

@Codelax Codelax marked this pull request as ready for review September 7, 2022 08:36
@codecov-commenter
Copy link

codecov-commenter commented Sep 7, 2022

Codecov Report

Merging #1456 (de18598) into master (ab81096) will increase coverage by 0.00%.
The diff coverage is 72.97%.

@@           Coverage Diff           @@
##           master    #1456   +/-   ##
=======================================
  Coverage   65.66%   65.66%           
=======================================
  Files         130      130           
  Lines       20862    20894   +32     
=======================================
+ Hits        13699    13721   +22     
- Misses       5971     5979    +8     
- Partials     1192     1194    +2     
Impacted Files Coverage Δ
...data_source_vpc_public_gateway_dhcp_reservation.go 55.55% <65.00%> (-0.51%) ⬇️
scaleway/helpers_vpcgw.go 85.24% <82.35%> (-1.12%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Monitob
Monitob previously approved these changes Sep 7, 2022
@Codelax Codelax merged commit 3e4e954 into scaleway:master Sep 7, 2022
@Codelax Codelax deleted the vpcgw_dhcp_reserv_wait branch September 7, 2022 09:56
Monitob pushed a commit to Monitob/terraform-provider-scaleway that referenced this pull request Sep 9, 2022
Monitob pushed a commit to Monitob/terraform-provider-scaleway that referenced this pull request Sep 9, 2022
Monitob pushed a commit to Monitob/terraform-provider-scaleway that referenced this pull request Sep 9, 2022
Monitob pushed a commit to Monitob/terraform-provider-scaleway that referenced this pull request Sep 9, 2022
Monitob pushed a commit to Monitob/terraform-provider-scaleway that referenced this pull request Sep 13, 2022
@Monitob Monitob added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vpc Virtual Private Cloud (VPC) issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants