Skip to content

Conversation

@quantumsheep
Copy link
Member

Resolves #1538

@quantumsheep quantumsheep added the tem Transactional Email issues, bugs and feature requests label Oct 28, 2022
@quantumsheep quantumsheep self-assigned this Oct 28, 2022
Copy link
Member

@Codelax Codelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quantumsheep and others added 2 commits October 28, 2022 16:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Attention: Patch coverage is 75.32468% with 57 lines in your changes missing coverage. Please review.

Project coverage is 64.66%. Comparing base (79576bc) to head (c5b91a1).
Report is 1098 commits behind head on master.

Files with missing lines Patch % Lines
scaleway/resource_tem_domain.go 78.10% 22 Missing and 8 partials ⚠️
scaleway/data_source_tem_domain.go 65.57% 14 Missing and 7 partials ⚠️
scaleway/helpers_tem.go 80.64% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1557      +/-   ##
==========================================
+ Coverage   64.51%   64.66%   +0.14%     
==========================================
  Files         136      139       +3     
  Lines       22077    22308     +231     
==========================================
+ Hits        14244    14425     +181     
- Misses       6615     6650      +35     
- Partials     1218     1233      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@quantumsheep quantumsheep merged commit 6354fdd into master Nov 2, 2022
@quantumsheep quantumsheep deleted the feat/tem-domain branch November 2, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement tem Transactional Email issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for domain in transactional email

5 participants