Skip to content

fix(provider): pass error when request failed to execute in retryclient #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2022
Merged

fix(provider): pass error when request failed to execute in retryclient #1569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion scaleway/retryable_transport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,15 @@ func newRetryableTransport(defaultTransport http.RoundTripper) http.RoundTripper
}
return retryablehttp.DefaultRetryPolicy(ctx, resp, err)
}

// If ErrorHandler is not set, retryablehttp will wrap http errors
c.ErrorHandler = func(resp *http.Response, err error, numTries int) (*http.Response, error) {
// Do not return error as response will be handled by scaleway sdk-go
// err is not nil if there was an error while performing request
// it should be passed, but do not create an error when request contains an error code
// http errors are handled by sdk coming after this transport
if err != nil {
return resp, err
}
return resp, nil
}

Expand Down