Skip to content

Conversation

@yfodil
Copy link
Contributor

@yfodil yfodil commented Jul 12, 2023

No description provided.

@yfodil yfodil added enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests labels Jul 12, 2023
@yfodil yfodil self-assigned this Jul 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2045 (3f4127b) into master (ff936d8) will increase coverage by 0.14%.
The diff coverage is 54.31%.

@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
+ Coverage   73.77%   73.91%   +0.14%     
==========================================
  Files         184      184              
  Lines       28880    29055     +175     
==========================================
+ Hits        21306    21476     +170     
- Misses       5743     5754      +11     
+ Partials     1831     1825       -6     
Impacted Files Coverage Δ
scaleway/resource_lb.go 70.32% <ø> (+4.50%) ⬆️
scaleway/resource_redis_cluster.go 76.43% <ø> (+4.22%) ⬆️
scaleway/helpers_vpc.go 42.69% <13.33%> (-29.98%) ⬇️
scaleway/resource_baremetal_server.go 75.24% <40.00%> (+0.81%) ⬆️
scaleway/helpers_lb.go 84.32% <50.00%> (-0.99%) ⬇️
scaleway/helpers_rdb.go 79.49% <50.00%> (-1.55%) ⬇️
scaleway/helpers_redis.go 84.44% <50.00%> (-3.32%) ⬇️
scaleway/resource_instance_private_nic.go 67.85% <50.00%> (-1.05%) ⬇️
scaleway/resource_vpc_gateway_network.go 62.75% <50.00%> (-0.63%) ⬇️
scaleway/data_source_vpc_private_network.go 54.68% <57.14%> (-4.97%) ⬇️
... and 3 more

... and 1 file with indirect coverage changes

yfodil and others added 3 commits July 12, 2023 15:34
Co-authored-by: Jules Castéran <jules.casteran@gmail.com>
Co-authored-by: Jules Castéran <jules.casteran@gmail.com>
@yfodil yfodil added this pull request to the merge queue Jul 13, 2023
Merged via the queue into scaleway:master with commit 476c467 Jul 13, 2023
@yfodil yfodil deleted the feat/migrate_from_zonal_to_regional branch July 13, 2023 08:56
@yfodil yfodil linked an issue Jul 20, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement vpc Virtual Private Cloud (VPC) issues, bugs and feature requests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for regional private network in datasource

3 participants