Skip to content

Conversation

@Codelax
Copy link
Member

@Codelax Codelax commented Dec 4, 2023

No description provided.

@Codelax Codelax self-assigned this Dec 4, 2023
@Codelax Codelax marked this pull request as draft December 4, 2023 15:05
@Codelax Codelax marked this pull request as ready for review January 9, 2024 14:59
@Codelax Codelax marked this pull request as draft January 9, 2024 15:14
@remyleone remyleone added the priority:high New features label Jan 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (efb40a2) 73.64% compared to head (cfc1b20) 73.63%.

Files Patch % Lines
scaleway/resource_sdb_sql_database.go 69.11% 30 Missing and 12 partials ⚠️
scaleway/helpers_sdb_sql.go 80.64% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
- Coverage   73.64%   73.63%   -0.02%     
==========================================
  Files         226      228       +2     
  Lines       35017    35185     +168     
==========================================
+ Hits        25790    25910     +120     
- Misses       7010     7044      +34     
- Partials     2217     2231      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Codelax Codelax marked this pull request as ready for review January 12, 2024 08:31
@remyleone remyleone added this pull request to the merge queue Jan 15, 2024
Merged via the queue into scaleway:master with commit 5a3c76a Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants