Skip to content

Conversation

@chambo-e
Copy link
Contributor

@chambo-e chambo-e commented Aug 10, 2022

Related to #548

@chambo-e chambo-e requested a review from a team August 10, 2022 14:23
@chambo-e chambo-e self-assigned this Aug 10, 2022
@chambo-e chambo-e requested review from fabienhebert and matthprost and removed request for a team August 10, 2022 14:23
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2022

size-limit report 📦

Path Size
dist/src/index.js, dist/react-datepicker/dist/react-datepicker.min.css.js, dist/react-toastify/dist/ReactToastify.min.css.js, dist/src/helpers/isJSON.js, dist/src/helpers/keycode.js, dist/src/helpers/legend.js, dist/src/helpers/numbers.js, dist/src/helpers/recursivelyGetChildrenString.js, dist/src/theme/index.js, dist/src/utils/animations.js, dist/src/utils/capitalize.js, dist/src/utils/ids.js, dist/src/utils/normalize.js, dist/src/utils/orderBy.js, dist/intl-tel-input/build/css/intlTelInput.css.js, dist/src/components/ActionBar/index.js, dist/src/components/Alert/index.js, dist/src/components/Avatar/index.js, dist/src/components/Badge/index.js, dist/src/components/BarChart/Tooltip.js, dist/src/components/BarChart/index.js, dist/src/components/BarStack/index.js, dist/src/components/BorderedBox/index.js, dist/src/components/Box/index.js, dist/src/components/Breadcrumbs/index.js, dist/src/components/Bullet/index.js, dist/src/components/Button/index.js, dist/src/components/Checkbox/index.js, dist/src/components/Container/index.js, dist/src/components/DateInput/index.js, dist/src/components/Description/index.js, dist/src/components/DotSteps/index.js, dist/src/components/Expandable/index.js, dist/src/components/FlexBox/index.js, dist/src/components/Grid/Col.js, dist/src/components/Grid/Grid.js, dist/src/components/Grid/Row.js, dist/src/components/Icon/index.js, dist/src/components/Image/index.js, dist/src/components/Label/index.js, dist/src/components/LineChart/CustomLegend.js, dist/src/components/LineChart/Tooltip.js, dist/src/components/LineChart/helpers.js, dist/src/components/LineChart/index.js, dist/src/components/Link/index.js, dist/src/components/List/Cell.js, dist/src/components/List/SelectBar.js, dist/src/components/List/SortIcon.js, dist/src/components/List/context.js, dist/src/components/List/index.js, dist/src/components/List/variantExplorer.js, dist/src/components/List/variantProduct.js, dist/src/components/List/variantTable.js, dist/src/components/Loader/index.js, dist/src/components/MarkDown/index.js, dist/src/components/Menu/Item.js, dist/src/components/Menu/index.js, dist/src/components/Modal/index.js, dist/src/components/NavigationStepper/index.js, dist/src/components/Notice/index.js, dist/src/components/Pagination/getPageNumbers.js, dist/src/components/Pagination/index.js, dist/src/components/Pagination/usePagination.js, dist/src/components/PasswordCheck/index.js, dist/src/components/PasswordStrengthMeter/index.js, dist/src/components/Pentagon/index.js, dist/src/components/PhoneInput/flags.png.js, dist/src/components/PhoneInput/index.js, dist/src/components/PieChart/Legends.js, dist/src/components/PieChart/Tooltip.js, dist/src/components/PieChart/index.js, dist/src/components/PieChart/patterns.js, dist/src/components/Placeholder/Block.js, dist/src/components/Placeholder/Blocks.js, dist/src/components/Placeholder/BoxWithIcon.js, dist/src/components/Placeholder/Donut.js, dist/src/components/Placeholder/IconPlaceholder.js, dist/src/components/Placeholder/Line.js, dist/src/components/Placeholder/List.js, dist/src/components/Placeholder/Slider.js, dist/src/components/Placeholder/index.js, dist/src/components/ProgressBar/index.js, dist/src/components/ProgressionButton/index.js, dist/src/components/Radio/index.js, dist/src/components/RadioBorderedBox/index.js, dist/src/components/Range/index.js, dist/src/components/RichSelect/index.js, dist/src/components/ScrollView/index.js, dist/src/components/SelectNumber/index.js, dist/src/components/SelectableCard/index.js, dist/src/components/Separator/index.js, dist/src/components/Slider/index.js, dist/src/components/Sphere/index.js, dist/src/components/StateBar/index.js, dist/src/components/Status/index.js, dist/src/components/StealthCopiable/index.js, dist/src/components/StepList/index.js, dist/src/components/Stepper/index.js, dist/src/components/Switch/index.js, dist/src/components/SwitchButton/index.js, dist/src/components/TabGroup/Tab.js, dist/src/components/TabGroup/index.js, dist/src/components/Table/index.js, dist/src/components/Tag/index.js, dist/src/components/Tags/index.js, dist/src/components/TagsPoplist/index.js, dist/src/components/Text/index.js, dist/src/components/TextBox/index.js, dist/src/components/TimeInput/index.js, dist/src/components/Toaster/index.js, dist/src/components/Tooltip/index.js, dist/src/components/TooltipIcon/index.js, dist/src/components/Touchable/index.js, dist/src/components/Typography/index.js, dist/src/components/UnitInput/index.js, dist/src/components/VerificationCode/index.js, dist/src/components/VolumeSize/index.js, dist/src/theme/tokens/dark.js, dist/src/theme/tokens/light.js, dist/src/utils/responsive/Breakpoint.js, dist/src/utils/responsive/utilities.js 186.05 KB (+0.01% 🔺)

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #1753 (fe095df) into main (de95174) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1753      +/-   ##
==========================================
+ Coverage   94.62%   94.76%   +0.13%     
==========================================
  Files         117      117              
  Lines        3291     3378      +87     
  Branches      483      497      +14     
==========================================
+ Hits         3114     3201      +87     
  Misses        128      128              
  Partials       49       49              
Impacted Files Coverage Δ
src/components/Notice/index.tsx 100.00% <100.00%> (ø)
src/components/TextBox/index.tsx 100.00% <100.00%> (ø)
src/components/Text/index.tsx 100.00% <0.00%> (ø)
src/components/DotSteps/index.tsx 100.00% <0.00%> (ø)
src/components/List/SelectBar.tsx 100.00% <0.00%> (ø)
src/components/Container/index.tsx 100.00% <0.00%> (ø)
src/components/BarChart/Tooltip.tsx 100.00% <0.00%> (ø)
src/components/LineChart/Tooltip.tsx 100.00% <0.00%> (ø)
src/components/TagsPoplist/index.tsx 100.00% <0.00%> (ø)
src/components/SelectableCard/index.tsx 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b61fb17...fe095df. Read the comment docs.

Copy link
Contributor

@matthprost matthprost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will also mean a migration on projects using Notice :)

@matthprost matthprost added the refactor Refactor without breaking changes label Aug 10, 2022
Co-authored-by: Matthias Prost <mprost@scaleway.com>
@matthprost matthprost added this to the v1 milestone Aug 11, 2022
@matthprost matthprost linked an issue Aug 11, 2022 that may be closed by this pull request
@matthprost matthprost removed a link to an issue Aug 11, 2022
@matthprost matthprost modified the milestones: v1, remove xstyled Aug 11, 2022
@chambo-e chambo-e merged commit c9488b0 into main Aug 11, 2022
@chambo-e chambo-e deleted the fix/remove_xstyled_notice branch August 11, 2022 17:16
scaleway-bot pushed a commit that referenced this pull request Aug 11, 2022
## [0.178.0](v0.177.1...v0.178.0) (2022-08-11)

### ⚡ Refactor

* remove flexbox usage ([#1752](#1752)) ([cabe0b4](cabe0b4))

### ⚙️ Features

* **Notice:** migrate from Box to div ([#1753](#1753)) ([c9488b0](c9488b0))

### 📦 Chore

* **devdeps:** update actions/cache action to v3.0.7 ([#1759](#1759)) ([958924d](958924d))
* **devdeps:** update pnpm to v7.9.0 ([#1766](#1766)) ([912c521](912c521))
@scaleway-bot
Copy link
Collaborator

🎉 This PR is included in version 0.178.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor without breaking changes released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants