Skip to content

Conversation

@lisalupi
Copy link
Collaborator

Summary

Type

  • Refactor

Summarise concisely:

What is expected?

ActionBar & Text: Use css variable instead of style with vanilla extract

@lisalupi lisalupi requested review from a team and philibea August 29, 2025 12:14
@lisalupi lisalupi self-assigned this Aug 29, 2025
@lisalupi lisalupi requested review from matthprost and removed request for a team August 29, 2025 12:14
@lisalupi lisalupi added the refactor Refactor without breaking changes label Aug 29, 2025
@lisalupi lisalupi requested review from a team and removed request for matthprost August 29, 2025 12:14
@lisalupi lisalupi requested review from a team and johnrazeur as code owners August 29, 2025 12:14
@changeset-bot
Copy link

changeset-bot bot commented Aug 29, 2025

🦋 Changeset detected

Latest commit: f614073

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/nextjs Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.10%. Comparing base (8a90258) to head (f614073).
⚠️ Report is 33 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #5478      +/-   ##
==========================================
- Coverage   92.18%   92.10%   -0.09%     
==========================================
  Files         234      244      +10     
  Lines        8060     8016      -44     
  Branches     3449     3388      -61     
==========================================
- Hits         7430     7383      -47     
- Misses        630      633       +3     
Files with missing lines Coverage Δ
packages/ui/src/components/ActionBar/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/ActionBar/styles.css.ts 100.00% <ø> (ø)
packages/ui/src/components/Badge/styles.css.ts 100.00% <ø> (ø)
packages/ui/src/components/Text/index.tsx 93.75% <ø> (-6.25%) ⬇️
packages/ui/src/components/Text/style.css.ts 100.00% <ø> (ø)
packages/ui/src/components/Text/variables.css.ts 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0eeaf...f614073. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lisalupi lisalupi force-pushed the fix/css-variable-vanilla-extract branch from 3db034f to f614073 Compare September 1, 2025 15:39
@lisalupi lisalupi merged commit cc62653 into beta Sep 1, 2025
15 checks passed
@lisalupi lisalupi deleted the fix/css-variable-vanilla-extract branch September 1, 2025 15:48
lisalupi added a commit that referenced this pull request Sep 4, 2025
lisalupi added a commit that referenced this pull request Sep 5, 2025
matthprost pushed a commit that referenced this pull request Sep 9, 2025
matthprost pushed a commit that referenced this pull request Sep 17, 2025
philibea pushed a commit that referenced this pull request Sep 17, 2025
philibea pushed a commit that referenced this pull request Sep 17, 2025
matthprost pushed a commit that referenced this pull request Sep 18, 2025
matthprost pushed a commit that referenced this pull request Oct 7, 2025
lisalupi added a commit that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants