Skip to content

Conversation

@ThibaultRiviere
Copy link
Contributor

Pull request template

Description

Motivation and context

Why is this change required? What problem does it solve?

Related issues

Please use the following link syntaxes #600 to reference issues in the
current repository

Checklist

Add tests to cover the changes

New tests added or existing tests modified to cover all changes

Code conforms with the style guide

Sign your work

In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change
as soon as we can.

@ghost
Copy link

ghost commented Feb 1, 2018

@bennettbuchanan any idea why this constantly fails on some Azure tests ? I can't understand what's failing from the change, but the error seems to be constant.

@bennettbuchanan
Copy link

@DavidPineauScality Looks like getAzureContainerName is missing a param that was added in master but is reverted here. https://github.com/scality/S3/pull/1092/files#diff-259359774bc4a7a93a170e43719bba53R8

@ironman-machine ironman-machine dismissed bennettbuchanan’s stale review February 1, 2018 21:52

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ghost
Copy link

ghost commented Feb 2, 2018

@bennettbuchanan Thanks :D !

@ghost ghost changed the title Fwdport 7.2 to master Fwdport 7.2 to rel/7.4 (formerly master) Feb 2, 2018
@ghost ghost changed the base branch from master to rel/7.4 February 2, 2018 10:40
@ghost
Copy link

ghost commented Feb 2, 2018

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again to @bennettbuchanan for the help

@ghost
Copy link

ghost commented Feb 2, 2018

Merging synchronously scality/bucketclient#128 #1092 scality/MetaData#1317 scality/sproxydclient#136 scality/Arsenal#404 scality/backbeat#170 scality/Integration#631 , scality/Federation#1310

@ghost ghost merged commit 1a2ca14 into rel/7.4 Feb 2, 2018
@ghost ghost deleted the fwdport_7.2_to_master branch February 2, 2018 14:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants