Improved logging and Replica set compatibility #1097

ssalaues · 2018-01-30T02:23:24Z

This allows for replica sets to be defined and used as the metadata backends

vrancurel · 2018-01-30T17:19:20Z

config.json

+       "database": "metadata"
+    },
+    "log": {
+	"logLevel": "trace"


it should not be trace

vrancurel · 2018-01-30T17:20:09Z

lib/metadata/mongoclient/backend.js

        MongoClient.connect(mongoUrl, (err, client) => {
            if (err) {
-                throw (errors.InternalError);
+                throw (err);


Not good here: We should log.error(err.message) (or similar field) and return errors.InternalError

vrancurel · 2018-01-30T17:20:27Z

lib/metadata/mongoclient/backend.js

                                      'attributes to metastore',
                                      { error: err });
-                    throw (errors.InternalError);
+                    throw (err);


Same for all errors ...

ironman-machine · 2018-01-30T19:06:33Z

PR has been updated. Reviewers, please be cautious.

bennettbuchanan · 2018-01-31T01:33:47Z

lib/metadata/mongoclient/backend.js

        // initialize this backend
        MongoClient.connect(mongoUrl, (err, client) => {
            if (err) {
+                this.logger.error('error connecting to mongo server', err);


For werelogs logging, the pattern is to have the second argument as an object containing additional information. For example, ...mongo server', { error: err });. I guess I would assume we should maintain that for these changes as well?

bennettbuchanan · 2018-01-31T18:31:27Z

@ironman-machine r+

ironman-machine · 2018-01-31T18:31:28Z

Hello @bennettbuchanan

"r+": Success

ironman-machine · 2018-01-31T18:31:28Z

There is already a pending pull request on the same branch

ironman-machine · 2018-01-31T18:47:51Z

⌛ PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/18941

ssalaues · 2018-01-31T19:41:58Z

Didn't realize I had some linting issues. Fixed the issues and should be okay now.

bennettbuchanan · 2018-01-31T19:55:46Z

@ironman-machine r+

ironman-machine · 2018-01-31T19:55:46Z

Hello @bennettbuchanan

"r+": Failure: Pull request isn't approved

bennettbuchanan · 2018-01-31T19:57:08Z

@ironman-machine r+

ironman-machine · 2018-01-31T19:57:08Z

Hello @bennettbuchanan

"r+": Failure: Pull request isn't approved

bennettbuchanan · 2018-01-31T20:03:21Z

@ironman-machine try

ironman-machine · 2018-01-31T20:03:23Z

Hello @bennettbuchanan

"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/18946' with the following env. args:

{
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "master",
    "SCALITY_S3_BRANCH": "ft/kub-mongo"
}

ironman-machine · 2018-01-31T21:15:03Z

☀️ 👍 circleCI test succeeded!

ssalaues · 2018-01-31T23:12:38Z

Failing the awssdk tests. Will make the necessary changes.

JianqinWang · 2018-02-01T00:53:45Z

lib/metadata/mongoclient/backend.js

            upsert: true,
-        }, () => cb());
+        }, err => {
+            log.error('putObjectNoVer: error putting obect with no versioning',


This line is causing error ""Cannot read property 'message' of null", needs an if (err) statement

vrancurel · 2018-02-01T18:45:43Z

@ironman-machine r+

ironman-machine · 2018-02-01T18:45:44Z

Hello @vrancurel

"r+": Failure: Pull request isn't approved

LaurenSpiegel · 2018-02-01T22:06:01Z

@ironman-machine r+

ironman-machine · 2018-02-01T22:06:02Z

Hello @LaurenSpiegel

"r+": Failure: Pull request isn't approved

LaurenSpiegel · 2018-02-01T22:06:29Z

@ironman-machine r+

ironman-machine · 2018-02-01T22:06:29Z

Hello @LaurenSpiegel

"r+": Success

ironman-machine · 2018-02-01T22:06:30Z

There is already a pending pull request on the same branch

LaurenSpiegel · 2018-02-01T22:07:26Z

@ironman-machine try

ironman-machine · 2018-02-01T22:07:28Z

Hello @LaurenSpiegel

"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/18998' with the following env. args:

{
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "master",
    "SCALITY_S3_BRANCH": "ft/kub-mongo"
}

ironman-machine · 2018-02-01T23:16:51Z

⌛ PR is now pending. CI build url: http://ci.ironmann.io/gh/scality/Integration/19001

ironman-machine · 2018-02-01T23:17:26Z

☀️ 👍 circleCI test succeeded!

vrancurel reviewed Jan 30, 2018

View reviewed changes

ssalaues force-pushed the ft/kub-mongo branch from 5409486 to 5e0c6b5 Compare January 30, 2018 19:06

ssalaues force-pushed the ft/kub-mongo branch from 5e0c6b5 to 8e4b5ba Compare January 30, 2018 19:29

vrancurel approved these changes Jan 30, 2018

View reviewed changes

ssalaues force-pushed the ft/kub-mongo branch 5 times, most recently from 1e45272 to 250283c Compare January 30, 2018 22:02

JianqinWang approved these changes Jan 31, 2018

View reviewed changes

ssalaues force-pushed the ft/kub-mongo branch from 250283c to 7dbcd4b Compare January 31, 2018 01:25

bennettbuchanan reviewed Jan 31, 2018

View reviewed changes

ssalaues force-pushed the ft/kub-mongo branch 3 times, most recently from dfbb3ac to 1848025 Compare January 31, 2018 18:20

bennettbuchanan approved these changes Jan 31, 2018

View reviewed changes

ssalaues force-pushed the ft/kub-mongo branch from 1848025 to 7204ac7 Compare January 31, 2018 19:41

bennettbuchanan approved these changes Jan 31, 2018

View reviewed changes

ssalaues force-pushed the ft/kub-mongo branch from 7204ac7 to ca741bf Compare January 31, 2018 23:18

Replica Set Compatibility

24ae398

ssalaues force-pushed the ft/kub-mongo branch from ca741bf to acf5473 Compare February 1, 2018 00:07

JianqinWang reviewed Feb 1, 2018

View reviewed changes

ssalaues force-pushed the ft/kub-mongo branch from acf5473 to c162c49 Compare February 1, 2018 01:11

Improved Mongo Loggging

d195267

ssalaues force-pushed the ft/kub-mongo branch from c162c49 to d195267 Compare February 1, 2018 01:46

JianqinWang approved these changes Feb 1, 2018

View reviewed changes

LaurenSpiegel closed this Feb 1, 2018

LaurenSpiegel reopened this Feb 1, 2018

LaurenSpiegel merged commit cd252ff into master Feb 1, 2018

LaurenSpiegel deleted the ft/kub-mongo branch February 1, 2018 23:37

Improved logging and Replica set compatibility #1097

Improved logging and Replica set compatibility #1097

Uh oh!

Conversation

ssalaues commented Jan 30, 2018

This allows for replica sets to be defined and used as the metadata backends

Uh oh!

vrancurel Jan 30, 2018

Choose a reason for hiding this comment

Uh oh!

vrancurel Jan 30, 2018

Choose a reason for hiding this comment

Uh oh!

vrancurel Jan 30, 2018

Choose a reason for hiding this comment

Uh oh!

ironman-machine commented Jan 30, 2018

Uh oh!

bennettbuchanan Jan 31, 2018

Choose a reason for hiding this comment

Uh oh!

bennettbuchanan commented Jan 31, 2018

Uh oh!

ironman-machine commented Jan 31, 2018

Uh oh!

ironman-machine commented Jan 31, 2018

Uh oh!

ironman-machine commented Jan 31, 2018

Uh oh!

ssalaues commented Jan 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bennettbuchanan commented Jan 31, 2018

Uh oh!

ironman-machine commented Jan 31, 2018

Uh oh!

bennettbuchanan commented Jan 31, 2018

Uh oh!

ironman-machine commented Jan 31, 2018

Uh oh!

bennettbuchanan commented Jan 31, 2018

Uh oh!

ironman-machine commented Jan 31, 2018

Uh oh!

ironman-machine commented Jan 31, 2018

Uh oh!

ssalaues commented Jan 31, 2018

Uh oh!

JianqinWang Feb 1, 2018

Choose a reason for hiding this comment

Uh oh!

vrancurel commented Feb 1, 2018

Uh oh!

ironman-machine commented Feb 1, 2018

Uh oh!

LaurenSpiegel commented Feb 1, 2018

Uh oh!

ironman-machine commented Feb 1, 2018

Uh oh!

LaurenSpiegel commented Feb 1, 2018

Uh oh!

ironman-machine commented Feb 1, 2018

Uh oh!

ironman-machine commented Feb 1, 2018

Uh oh!

LaurenSpiegel commented Feb 1, 2018

Uh oh!

ironman-machine commented Feb 1, 2018

Uh oh!

ironman-machine commented Feb 1, 2018

Uh oh!

ironman-machine commented Feb 1, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

ssalaues commented Jan 31, 2018 •

edited

Loading