Skip to content

Ft/s3 c 1115/gcp object #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2018
Merged

Ft/s3 c 1115/gcp object #1113

merged 2 commits into from
Feb 14, 2018

Conversation

@alexanderchan-scality
Copy link
Contributor

@alexanderchan-scality alexanderchan-scality commented Feb 8, 2018 •
edited
Loading

Changing base from master to feature branch ft/GCP
Refer to #1095
Also includes the fix, but separate to show the commit history done on master.
Refer to #1107

@alexanderchan-scality alexanderchan-scality changed the base branch from master to rel/7.4 February 8, 2018 02:57
@alexanderchan-scality
Copy link
Contributor Author

alexanderchan-scality commented Feb 8, 2018

@ironman-machine try

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 8, 2018

Hello @alexanderchan-scality

"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/19161' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "ft/S3C-1115/GCP-Object"
}

jonathan-gramain
jonathan-gramain previously approved these changes Feb 8, 2018
View reviewed changes
Copy link
Contributor

@jonathan-gramain jonathan-gramain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validating considering the same code has been reviewed and pushed to master.

@alexanderchan-scality alexanderchan-scality changed the base branch from rel/7.4 to ft/GCP February 9, 2018 00:31
@alexanderchan-scality
Copy link
Contributor Author

alexanderchan-scality commented Feb 9, 2018

@ironman-machine
DEFAULT_BRANCH=rel/7.4
SCALITY_INTEGRATION_BRANCH=ultron/rel/7.4
SCALITY_S3_BRANCH=ft/S3C-1115/GCP-Object
try

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 9, 2018

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4": Success
"SCALITY_INTEGRATION_BRANCH=ultron/rel/7.4": Success
"SCALITY_S3_BRANCH=ft/S3C-1115/GCP-Object": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/19246' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "ft/S3C-1115/GCP-Object"
}

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 9, 2018

💔 ☔ circleCI test failed.

@alexanderchan-scality
Copy link
Contributor Author

alexanderchan-scality commented Feb 12, 2018

@ironman-machine
DEFAULT_BRANCH=rel/7.4
SCALITY_INTEGRATION_BRANCH=ultron/rel/7.4
SCALITY_S3_BRANCH=ft/S3C-1115/GCP-Object
try

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 12, 2018

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4": Success
"SCALITY_INTEGRATION_BRANCH=ultron/rel/7.4": Success
"SCALITY_S3_BRANCH=ft/S3C-1115/GCP-Object": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/19341' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "ft/S3C-1115/GCP-Object"
}

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 12, 2018

💔 ☔ circleCI test failed.

@ironman-machine ironman-machine dismissed jonathan-gramain’s stale review February 13, 2018 14:23

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 13, 2018

PR has been updated. Reviewers, please be cautious.

@alexanderchan-scality
S3C-1115 FT: GCP Object APIs
1be83ce 
Implements GCP Object PUT/GET/GET/DELETE APIs
@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 14, 2018

PR has been updated. Reviewers, please be cautious.

@alexanderchan-scality
FX: GCP PUT API Test
7c2f210 
Fixes the use of an undefined variable that leads to creation of buckets
that aren't deleted on GCP.
@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 14, 2018

PR has been updated. Reviewers, please be cautious.

@alexanderchan-scality
Copy link
Contributor Author

alexanderchan-scality commented Feb 14, 2018

@ironman-machine
DEFAULT_BRANCH="rel/7.4"
SCALITY_INTEGRATION_BRANCH="ultron/rel/7.4"
REPO_NAME="S3"
SCALITY_S3_BRANCH="ft/S3C-1115/GCP-Object"
try

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 14, 2018

Hello @alexanderchan-scality

"DEFAULT_BRANCH="rel/7.4"": Success
"SCALITY_INTEGRATION_BRANCH="ultron/rel/7.4"": Success
"REPO_NAME="S3"": Success
"SCALITY_S3_BRANCH="ft/S3C-1115/GCP-Object"": Success
"try": Failure: trigger_ci_build error: request failed with status code: 400

@alexanderchan-scality
Copy link
Contributor Author

alexanderchan-scality commented Feb 14, 2018

@ironman-machine clean_env

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 14, 2018

Hello @alexanderchan-scality

"clean_env": Success: Environment variables and after dependencies have been removed.

@alexanderchan-scality
Copy link
Contributor Author

alexanderchan-scality commented Feb 14, 2018

DEFAULT_BRANCH=rel/7.4
SCALITY_INTEGRATION_BRANCH=ultron/rel/7.4
SCALITY_S3_BRANCH=ft/S3C-1115/GCP-Object
try

@alexanderchan-scality
Copy link
Contributor Author

alexanderchan-scality commented Feb 14, 2018

@ironman-machine
DEFAULT_BRANCH=rel/7.4
SCALITY_INTEGRATION_BRANCH=ultron/rel/7.4
SCALITY_S3_BRANCH=ft/S3C-1115/GCP-Object
try

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 14, 2018

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4": Success
"SCALITY_INTEGRATION_BRANCH=ultron/rel/7.4": Success
"SCALITY_S3_BRANCH=ft/S3C-1115/GCP-Object": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/19422' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "ft/S3C-1115/GCP-Object"
}

@ironman-machine
Copy link
Contributor

ironman-machine commented Feb 14, 2018

☀️ 👍 circleCI test succeeded!

@bennettbuchanan bennettbuchanan merged commit 173436b into ft/GCP Feb 14, 2018
@bennettbuchanan bennettbuchanan deleted the ft/S3C-1115/GCP-Object branch February 14, 2018 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes

+1 more reviewer

@bennettbuchanan bennettbuchanan bennettbuchanan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexanderchan-scality @ironman-machine @jonathan-gramain @bennettbuchanan