Fx/gcp put test #1114
Closed
Fx/gcp put test #1114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ironman-machine try |
Contributor
|
Hello @alexanderchan-scality "try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/19160' with the following env. args: {
"DEFAULT_BRANCH": "rel/7.4",
"SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4",
"REPO_NAME": "S3",
"SCALITY_S3_BRANCH": "fx/GCP-PUT-TEST"
} |
jonathan-gramain
previously approved these changes
Feb 8, 2018
Contributor
jonathan-gramain
left a comment
jonathan-gramain
left a comment
There was a problem hiding this comment.
Validating considering the same code has been reviewed and pushed to master.
Removes one layer of nesting that leads to errors not being detected.
Implements GCP Object PUT/GET/GET/DELETE APIs
Fixes the use of an undefined variable that leads to creation of buckets that aren't deleted on GCP.
alexanderchan-scality
force-pushed
the
fx/GCP-PUT-TEST
branch
from
347114b to
4a5216b
Compare
ironman-machine
dismissed
jonathan-gramain’s stale review
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
Contributor
|
PR has been updated. Reviewers, please be cautious. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing base from master to feature branch ft/GCP
Refer to #1107