Skip to content

Ft/objdel add modified header check #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2018
Merged

Ft/objdel add modified header check #1145

merged 1 commit into from
Apr 11, 2018

Conversation

@dora-korpar
Copy link
Contributor

@dora-korpar dora-korpar commented Mar 6, 2018 •
edited
Loading

Adds check for date modified headers in objectDelete API

Depends on scality/Arsenal#435

philipyoo
philipyoo reviewed Mar 6, 2018
View reviewed changes
lib/api/objectDelete.js Outdated
if (err) {
return process.nextTick(() => next(err, bucketMD));
}
return process.nextTick(() =>
Copy link
Contributor

@philipyoo philipyoo Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curious, why process.nextTick?

Copy link
Contributor Author

@dora-korpar dora-korpar Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cos everything in the function is synchronous, so we gotta mimic async :)

Copy link
Contributor

@philipyoo philipyoo Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool beans ty for the explanation :)

rahulreddy
rahulreddy reviewed Mar 6, 2018
View reviewed changes
lib/api/objectDelete.js Outdated
if (err) {
return process.nextTick(() => next(err, bucketMD));
}
return process.nextTick(() =>
Copy link
Collaborator

@rahulreddy rahulreddy Mar 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This return is redundant as it will go the next one anyways.

@ironman-machine ironman-machine dismissed alexanderchan-scality’s stale review March 6, 2018 01:59

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Mar 6, 2018

PR has been updated. Reviewers, please be cautious.

philipyoo
philipyoo previously approved these changes Mar 6, 2018
View reviewed changes
@dora-korpar dora-korpar force-pushed the ft/objdel-add-modified-header-check branch from ec8f027 to 239db56 Compare March 7, 2018 18:26
@ironman-machine ironman-machine dismissed philipyoo’s stale review March 7, 2018 18:26

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Mar 7, 2018

PR has been updated. Reviewers, please be cautious.

@dora-korpar dora-korpar force-pushed the ft/objdel-add-modified-header-check branch from 239db56 to 98c25f9 Compare April 11, 2018 00:06
@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 11, 2018

PR has been updated. Reviewers, please be cautious.

@dora-korpar dora-korpar force-pushed the ft/objdel-add-modified-header-check branch from 98c25f9 to a02d226 Compare April 11, 2018 00:33
@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 11, 2018

PR has been updated. Reviewers, please be cautious.

@rahulreddy rahulreddy merged commit abc4fd2 into master Apr 11, 2018
@rahulreddy rahulreddy deleted the ft/objdel-add-modified-header-check branch April 11, 2018 03:20
BourgoisMickael added a commit that referenced this pull request Sep 16, 2025
@BourgoisMickael
CLDSRV-741: Test functional delObject conditional
94d0269 
Tests for this #1145
To run in Integration

See S3C-10376
@BourgoisMickael BourgoisMickael mentioned this pull request Sep 16, 2025
Merged
BourgoisMickael added a commit that referenced this pull request Sep 16, 2025
@BourgoisMickael
CLDSRV-741: Test functional delObject conditional
337a0bc 
Tests for this #1145
To run in Integration

See S3C-10376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahulreddy rahulreddy rahulreddy approved these changes

+2 more reviewers

@alexanderchan-scality alexanderchan-scality alexanderchan-scality left review comments

@philipyoo philipyoo philipyoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dora-korpar @ironman-machine @rahulreddy @alexanderchan-scality @philipyoo