Skip to content

FT: Add changes for replication with GCP #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2018
Merged

FT: Add changes for replication with GCP #1154

merged 1 commit into from
Apr 10, 2018

Conversation

@bennettbuchanan
Copy link

@bennettbuchanan bennettbuchanan commented Mar 9, 2018

No description provided.

@bennettbuchanan bennettbuchanan force-pushed the ft/ZENKO-158/add-gcp-support-for-one-to-many branch from 2e7f205 to f6242a0 Compare March 9, 2018 22:27
@ironman-machine
Copy link
Contributor

ironman-machine commented Mar 9, 2018

PR has been updated. Reviewers, please be cautious.

JianqinWang
JianqinWang previously approved these changes Mar 9, 2018
View reviewed changes
dora-korpar
dora-korpar previously approved these changes Mar 9, 2018
View reviewed changes
ploki
ploki previously approved these changes Mar 9, 2018
View reviewed changes
Copy link
Contributor

@ploki ploki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

constants.js Outdated
legacyLocations: ['sproxyd', 'legacy'],
/* eslint-disable camelcase */
externalBackends: { aws_s3: true, azure: true, gcp: true },
replicationBackends: ['aws_s3', 'azure', 'gcp'],
Copy link
Contributor

@ploki ploki Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might prefer the same construct as for the externalBackends constant

Copy link
Author

@bennettbuchanan bennettbuchanan Mar 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Updated!

@bennettbuchanan bennettbuchanan force-pushed the ft/ZENKO-158/add-gcp-support-for-one-to-many branch from f6242a0 to 8977df6 Compare March 9, 2018 22:42
@ironman-machine ironman-machine dismissed stale reviews from JianqinWang, dora-korpar, ploki, and alexanderchan-scality March 9, 2018 22:42

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Mar 9, 2018

PR has been updated. Reviewers, please be cautious.

ploki
ploki previously approved these changes Mar 9, 2018
View reviewed changes
@rahulreddy rahulreddy changed the base branch from ft/GCP to master April 4, 2018 21:47
@bennettbuchanan bennettbuchanan force-pushed the ft/ZENKO-158/add-gcp-support-for-one-to-many branch from 8977df6 to 930089b Compare April 6, 2018 01:01
@ironman-machine ironman-machine dismissed stale reviews from ploki, alexanderchan-scality, and rachedbenmustapha April 6, 2018 01:01

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 6, 2018

PR has been updated. Reviewers, please be cautious.

@bennettbuchanan bennettbuchanan force-pushed the ft/ZENKO-158/add-gcp-support-for-one-to-many branch from 930089b to 0d69556 Compare April 6, 2018 01:02
@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 6, 2018

PR has been updated. Reviewers, please be cautious.

@bennettbuchanan bennettbuchanan force-pushed the ft/ZENKO-158/add-gcp-support-for-one-to-many branch from 0d69556 to bb4106c Compare April 6, 2018 01:03
@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 6, 2018

PR has been updated. Reviewers, please be cautious.

@bennettbuchanan bennettbuchanan force-pushed the ft/ZENKO-158/add-gcp-support-for-one-to-many branch from bb4106c to 81d942f Compare April 6, 2018 18:15
@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 6, 2018

PR has been updated. Reviewers, please be cautious.

rahulreddy
rahulreddy previously approved these changes Apr 6, 2018
View reviewed changes
@bennettbuchanan bennettbuchanan force-pushed the ft/ZENKO-158/add-gcp-support-for-one-to-many branch from 81d942f to 85dee35 Compare April 9, 2018 20:01
@ironman-machine ironman-machine dismissed stale reviews from alexanderchan-scality and rahulreddy April 9, 2018 20:01

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

PR has been updated. Reviewers, please be cautious.

@bennettbuchanan
Copy link
Author

bennettbuchanan commented Apr 9, 2018

@ironman-machine r+

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

Hello @bennettbuchanan

"r+": Success

@bennettbuchanan
Copy link
Author

bennettbuchanan commented Apr 9, 2018

@ironman-machine r-

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

Hello @bennettbuchanan

"r-": Success

@bennettbuchanan
Copy link
Author

bennettbuchanan commented Apr 9, 2018

@ironman-machine
RUN_BACKBEAT_CRR_TESTS=1
r+

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

Hello @bennettbuchanan

"RUN_BACKBEAT_CRR_TESTS=1": Success
"r+": Success

@bennettbuchanan
Copy link
Author

bennettbuchanan commented Apr 9, 2018

@ironman-machine
RUN_BACKBEAT_CRR_TESTS=1
try

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

Hello @bennettbuchanan

"RUN_BACKBEAT_CRR_TESTS=1": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/21086' with the following env. args:

{
    "RUN_BACKBEAT_CRR_TESTS": "1",
    "DEFAULT_BRANCH": "master",
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "ft/ZENKO-158/add-gcp-support-for-one-to-many"
}

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

💔 ☔ circleCI test failed.

@bennettbuchanan
Copy link
Author

bennettbuchanan commented Apr 9, 2018

@ironman-machine
RUN_BACKBEAT_CRR_TESTS=1
try

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

Hello @bennettbuchanan

"RUN_BACKBEAT_CRR_TESTS=1": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/21087' with the following env. args:

{
    "RUN_BACKBEAT_CRR_TESTS": "1",
    "DEFAULT_BRANCH": "master",
    "SCALITY_INTEGRATION_BRANCH": "ultron/master",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "ft/ZENKO-158/add-gcp-support-for-one-to-many"
}

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 10, 2018

☀️ 👍 circleCI test succeeded!

@bennettbuchanan bennettbuchanan merged commit cf90391 into master Apr 10, 2018
@bennettbuchanan bennettbuchanan deleted the ft/ZENKO-158/add-gcp-support-for-one-to-many branch April 10, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahulreddy rahulreddy rahulreddy approved these changes

+5 more reviewers

@alexanderchan-scality alexanderchan-scality alexanderchan-scality approved these changes

@ploki ploki ploki left review comments

@JianqinWang JianqinWang JianqinWang left review comments

@rachedbenmustapha rachedbenmustapha rachedbenmustapha left review comments

@dora-korpar dora-korpar dora-korpar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@bennettbuchanan @ironman-machine @rahulreddy @ploki @JianqinWang @alexanderchan-scality @rachedbenmustapha @dora-korpar