Skip to content

Conversation

@alexanderchan-scality
Copy link
Contributor

@alexanderchan-scality alexanderchan-scality commented Mar 16, 2018

the missing err argument will cause S3 to crash as the logger will attempt to read the message property from an undefined.
fix: passes err to be returned in callback

@alexanderchan-scality
Copy link
Contributor Author

@ironman-machine
DEFAULT_BRANCH=rel/7.4
SCALITY_FEDERATION_BRANCH=ft/GCP
SCALITY_INTEGRATION_BRANCH=ft/GCP
try

@ironman-machine
Copy link
Contributor

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4": Success
"SCALITY_FEDERATION_BRANCH=ft/GCP": Success
"SCALITY_INTEGRATION_BRANCH=ft/GCP": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20451' with the following env. args:

{
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ft/GCP",
    "SCALITY_FEDERATION_BRANCH": "ft/GCP",
    "SCALITY_S3_BRANCH": "fx/gcp-add-err"
}

@ironman-machine
Copy link
Contributor

💔 ☔ circleCI test failed.

@alexanderchan-scality
Copy link
Contributor Author

@ironman-machine
DEFAULT_BRANCH=rel/7.4
SCALITY_FEDERATION_BRANCH=ft/GCP
SCALITY_INTEGRATION_BRANCH=ft/GCP
try

@ironman-machine
Copy link
Contributor

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4": Success
"SCALITY_FEDERATION_BRANCH=ft/GCP": Success
"SCALITY_INTEGRATION_BRANCH=ft/GCP": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20455' with the following env. args:

{
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ft/GCP",
    "SCALITY_FEDERATION_BRANCH": "ft/GCP",
    "SCALITY_S3_BRANCH": "fx/gcp-add-err"
}

@ironman-machine
Copy link
Contributor

☀️ 👍 circleCI test succeeded!

@bennettbuchanan bennettbuchanan merged commit 70379f2 into ft/GCP Mar 16, 2018
@bennettbuchanan bennettbuchanan deleted the fx/gcp-add-err branch March 16, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants