fx: use core querysting instead of qs module

[alexanderchan-scality]

Includes S3 PR #1167

[alexanderchan-scality]

@ironman-machine
DEFAULT_BRANCH=rel/7.4
try

[ironman-machine]

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20503' with the following env. args:

{
    "REPO_NAME": "S3",
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4",
    "SCALITY_S3_BRANCH": "fx/use-core-querystring"
}

[ironman-machine]

☀️ 👍 circleCI test succeeded!

[ploki]

Just surprised there's no reference to the qs module in the dependencies section of the package.json file.
I believe the querystring module is a drop in replacement for the qs module.

[JianqinWang]

@alexanderchan-scality was the dependency in package.json removed in a different pr and this is a follow-up fix?

[alexanderchan-scality]

@ploki yeah. Another S3 dep. has qs as one of its dependencies, so this missing qs dep wasn't flagged as an error. querystring is used instead since it is one of the core nodejs modules.
@JianqinWang qs dep wasn't added, I had missed it due to the reasons above.

[jeremyds]

I guess it has an impact on #1167 right?

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

[ironman-machine]

PR has been updated. Reviewers, please be cautious.

[alexanderchan-scality]

@ironman-machine
DEFAULT_BRANCH=rel/7.4
try

[ironman-machine]

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20535' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "fx/use-core-querystring"
}

[alexanderchan-scality]

Passing E2E: http://ci.ironmann.io/gh/scality/Integration/20536

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

[ironman-machine]

PR has been updated. Reviewers, please be cautious.

[alexanderchan-scality]

@ironman-machine
DEFAULT_BRANCH=rel/7.4
try

[ironman-machine]

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20556' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.4",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "fx/use-core-querystring"
}

[ironman-machine]

💔 ☔ circleCI test failed.

[alexanderchan-scality]

@ironman-machine
DEFAULT_BRANCH=rel/7.4
try

[alexanderchan-scality]

passing e2e: http://ci.ironmann.io/gh/scality/Integration/20561