FIX: Do not include untrimmed headers #1175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nicolas2bert merged 1 commit into z/1.0 from fix/do-not-include-untrimmed-headers-for-MPU-to-aws

Apr 25, 2018

bennettbuchanan commented Mar 20, 2018 •

edited

Loading

When putting an MPU object using an AWS location constraint, any user metadata is included twice.

Example response from a headObject request:

{
    "AcceptRanges": "bytes",
    "ContentType": "application/octet-stream",
    "LastModified": "Tue, 20 Mar 2018 22:11:39 GMT",
    "ContentLength": 10485762,
    "VersionId": "rbu8wlrAt7Jd_HUV9VctoSp3mIjQtg4M",
    "ETag": "\"794898c411e565027c2c3ba534b00e2d-2\"",
    "Metadata": {
        "x-amz-meta-customkey": "customValue",
        "customkey": "customValue"
    }
}

Author

bennettbuchanan commented Mar 20, 2018

@ironman-machine try

Contributor

ironman-machine commented Mar 20, 2018

Hello @bennettbuchanan

"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20568' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.2",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.2",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "fix/do-not-include-untrimmed-headers-for-MPU-to-aws"
}

Author

bennettbuchanan commented Mar 20, 2018

@ironman-machine
RUN_BACKBEAT_CRR_TESTS=True
try

Contributor

ironman-machine commented Mar 20, 2018

Hello @bennettbuchanan

"RUN_BACKBEAT_CRR_TESTS=True": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20574' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.2",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.2",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "fix/do-not-include-untrimmed-headers-for-MPU-to-aws",
    "RUN_BACKBEAT_CRR_TESTS": "True"
}

Contributor

ironman-machine commented Mar 21, 2018

PR has been updated. Reviewers, please be cautious.

Contributor

ironman-machine commented Mar 21, 2018

CONFLICT (add/add): Merge conflict in lib/routes/routeBackbeat.js
CONFLICT (add/add): Merge conflict in lib/data/external/AwsClient.js

Contributor

ironman-machine commented Mar 21, 2018

☀️ 👍 circleCI test succeeded!

Contributor

ironman-machine commented Mar 21, 2018

PR has been updated. Reviewers, please be cautious.

bennettbuchanan force-pushed the fix/do-not-include-untrimmed-headers-for-MPU-to-aws branch from ce1176c to 1e3d9d7 Compare

April 24, 2018 17:16

Contributor

ironman-machine commented Apr 24, 2018

PR has been updated. Reviewers, please be cautious.

bennettbuchanan changed the base branch from rel/7.2 to z/1.0

April 24, 2018 17:21

dora-korpar previously approved these changes

View reviewed changes

bennettbuchanan added the prio-high label

philipyoo previously approved these changes

View reviewed changes

bennettbuchanan force-pushed the fix/do-not-include-untrimmed-headers-for-MPU-to-aws branch from 1e3d9d7 to da97719 Compare

April 24, 2018 18:49

ironman-machine dismissed stale reviews from dora-korpar and philipyoo

April 24, 2018 18:49

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

Contributor

ironman-machine commented Apr 24, 2018

PR has been updated. Reviewers, please be cautious.


          FIX: Do not include untrimmed headers

d02dbeb

bennettbuchanan force-pushed the fix/do-not-include-untrimmed-headers-for-MPU-to-aws branch from da97719 to d02dbeb Compare

April 25, 2018 17:22

Contributor

ironman-machine commented Apr 25, 2018

PR has been updated. Reviewers, please be cautious.

philipyoo approved these changes

View reviewed changes

dora-korpar approved these changes

View reviewed changes

nicolas2bert merged commit d759593 into z/1.0

bennettbuchanan deleted the fix/do-not-include-untrimmed-headers-for-MPU-to-aws branch

December 12, 2018 00:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels