Skip to content

Conversation

@alexanderchan-scality
Copy link
Contributor

@alexanderchan-scality alexanderchan-scality commented Mar 29, 2018

externally handled MPU will return ContentLength as string, and this is failing the utapi push metrics assertion, in which requires ContentLength must be an integer

philipyoo
philipyoo previously approved these changes Mar 29, 2018
@ironman-machine ironman-machine dismissed stale reviews from philipyoo and jonathan-gramain March 29, 2018 23:21

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@alexanderchan-scality
Copy link
Contributor Author

@ironman-machine DEFAULT_BRANCH=rel/7.4-beta
RUN_BACKBEAT_CRR_TESTS=true
try

@ironman-machine
Copy link
Contributor

Hello @alexanderchan-scality

"DEFAULT_BRANCH=rel/7.4-beta": Success
"RUN_BACKBEAT_CRR_TESTS=true": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20857' with the following env. args:

{
    "DEFAULT_BRANCH": "rel/7.4-beta",
    "RUN_BACKBEAT_CRR_TESTS": "true",
    "SCALITY_INTEGRATION_BRANCH": "ultron/rel/7.4-beta",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "bf/content-length-type"
}

@alexanderchan-scality
Copy link
Contributor Author

@ironman-machine clean_env

@ironman-machine
Copy link
Contributor

Hello @alexanderchan-scality

"clean_env": Success: Environment variables and after dependencies have been removed.

@alexanderchan-scality
Copy link
Contributor Author

@ironman-machine
SCALITY_INTEGRATION_BRANCH=rel/7.4-beta
SCALITY_FEDERATION_BRANCH=rel/7.4-beta
RUN_BACKBEAT_CRR_TESTS=true
try

@ironman-machine
Copy link
Contributor

Hello @alexanderchan-scality

"SCALITY_INTEGRATION_BRANCH=rel/7.4-beta": Success
"SCALITY_FEDERATION_BRANCH=rel/7.4-beta": Success
"RUN_BACKBEAT_CRR_TESTS=true": Success
"try": Success: Try build successfully launched on 'http://ci.ironmann.io/gh/scality/Integration/20879' with the following env. args:

{
    "SCALITY_INTEGRATION_BRANCH": "rel/7.4-beta",
    "SCALITY_FEDERATION_BRANCH": "rel/7.4-beta",
    "RUN_BACKBEAT_CRR_TESTS": "true",
    "DEFAULT_BRANCH": "rel/7.4-beta",
    "REPO_NAME": "S3",
    "SCALITY_S3_BRANCH": "bf/content-length-type"
}

rahulreddy
rahulreddy previously approved these changes Mar 30, 2018
@ironman-machine
Copy link
Contributor

☀️ 👍 circleCI test succeeded!

@ironman-machine ironman-machine dismissed rahulreddy’s stale review March 30, 2018 18:34

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

PR has been updated. Reviewers, please be cautious.

@rahulreddy rahulreddy merged commit 063086c into rel/7.4-beta Mar 30, 2018
@rahulreddy rahulreddy deleted the bf/content-length-type branch March 30, 2018 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants