Skip to content

Fix mongo tests #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2018
Merged

Fix mongo tests #1188

merged 1 commit into from
Apr 11, 2018

Conversation

@ssalaues
Copy link

@ssalaues ssalaues commented Mar 30, 2018

Fixes the problem where the functional tests with mongo would not run correctly causing CircleCi to falsely pass.

Uploaded a new ci-mongo docker image based off Federation and that self initializes to a single node replica set for compatibility.

dora-korpar
dora-korpar previously approved these changes Mar 30, 2018
View reviewed changes
jeremyds
jeremyds previously approved these changes Mar 30, 2018
View reviewed changes
JianqinWang
JianqinWang previously approved these changes Mar 30, 2018
View reviewed changes
@ironman-machine ironman-machine dismissed stale reviews from dora-korpar, jeremyds, jonathan-gramain, and JianqinWang March 30, 2018 17:39

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Mar 30, 2018

PR has been updated. Reviewers, please be cautious.

rahulreddy
rahulreddy previously approved these changes Mar 30, 2018
View reviewed changes
JianqinWang
JianqinWang previously approved these changes Mar 30, 2018
View reviewed changes
@ssalaues
Copy link
Author

ssalaues commented Mar 30, 2018

Added exit $? at the end of the script so it always returns the last exit code instead of forcing an exit 0

@ssalaues ssalaues mentioned this pull request Apr 5, 2018
Merged
@ironman-machine ironman-machine dismissed stale reviews from rahulreddy and JianqinWang April 9, 2018 17:51

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 9, 2018

PR has been updated. Reviewers, please be cautious.

@ssalaues
Copy link
Author

ssalaues commented Apr 9, 2018

Rebased and fixed conflicts

vrancurel
vrancurel previously approved these changes Apr 9, 2018
View reviewed changes
dora-korpar
dora-korpar previously approved these changes Apr 9, 2018
View reviewed changes
nicolas2bert
nicolas2bert previously approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@nicolas2bert nicolas2bert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner 🥇

@ironman-machine ironman-machine dismissed vrancurel’s stale review April 10, 2018 05:22

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine ironman-machine dismissed stale reviews from dora-korpar and nicolas2bert April 10, 2018 05:22

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 10, 2018

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 10, 2018

PR has been updated. Reviewers, please be cautious.

1 similar comment
@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 10, 2018

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 10, 2018

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 10, 2018

PR has been updated. Reviewers, please be cautious.

@ssalaues
Copy link
Author

ssalaues commented Apr 10, 2018

Tests have been split up to run individually so we can set the REMOTE_MANAGEMENT_DISABLED flag as needed for the management tests.

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 10, 2018

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 11, 2018

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

ironman-machine commented Apr 11, 2018

PR has been updated. Reviewers, please be cautious.

@ssalaues
Copy link
Author

ssalaues commented Apr 11, 2018

Rebased and changed the ci-mongo image to 3.4

@rahulreddy rahulreddy merged commit 0fd0493 into master Apr 11, 2018
@rahulreddy rahulreddy deleted the fix/mongo-tests branch April 11, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rahulreddy rahulreddy rahulreddy left review comments

@jonathan-gramain jonathan-gramain jonathan-gramain left review comments

@nicolas2bert nicolas2bert nicolas2bert left review comments

+5 more reviewers

@JianqinWang JianqinWang JianqinWang approved these changes

@alexanderchan-scality alexanderchan-scality alexanderchan-scality approved these changes

@dora-korpar dora-korpar dora-korpar approved these changes

@vrancurel vrancurel vrancurel left review comments

@jeremyds jeremyds jeremyds left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.