FX: functional tests #1190
Merged
FX: functional tests #1190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas2bert
force-pushed
the
fx/functional-tests
branch
from
ac932d5 to
ff6df3f
Compare
Contributor
|
PR has been updated. Reviewers, please be cautious. |
1 similar comment
Contributor
|
PR has been updated. Reviewers, please be cautious. |
Contributor
|
nicolas2bert
commented
Apr 3, 2018
| it('should contain config', done => { | ||
| queryReport(done, response => { | ||
| if (!response.config || !response.config.locationConstraints) { | ||
| if (!response.config || !response.config.overlayVersion) { |
Contributor
Author
There was a problem hiding this comment.
NOTE: The way we do the report config cleanup has changed: https://github.com/scality/S3/pull/1183/files#diff-2157ec89ef3a5f5eefc407fecbdba988R14
nicolas2bert
force-pushed
the
fx/functional-tests
branch
from
ee6511c to
abfd54f
Compare
Contributor
|
PR has been updated. Reviewers, please be cautious. |
rachedbenmustapha
approved these changes
Apr 3, 2018
jeremyds
approved these changes
Apr 3, 2018
nicolas2bert
added a commit
that referenced
this pull request
Apr 5, 2018
* FX: functional tests * [SQUASH ME] FX TESTS: cleanup(config) changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes should fix our tests.
This check was not skipping tests: https://github.com/scality/S3/blob/master/tests/functional/aws-node-sdk/test/multipleBackend/utils.js#L40