bf: ZENKO-250 correctly evaluate regex pattern #1232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
rahulreddy
previously approved these changes
Apr 27, 2018
dora-korpar
previously approved these changes
Apr 27, 2018
| */ | ||
| function parseLikeExpression(regex) { | ||
| const split = regex.split('/'); | ||
| if (split.length < 3) { |
Contributor
There was a problem hiding this comment.
Shouldn't we include the case where split[0] != '' here, i.e. checking if regex starts with a slash?
Contributor
Author
There was a problem hiding this comment.
Yes. you're correct, I should be checking if the leading character is a slash. Will fix this.
alexanderchan-scality
force-pushed
the
bf/ZENKO-250-regexEval
branch
from
545f214 to
5f4cc79
Compare
ironman-machine
dismissed stale reviews from rahulreddy and dora-korpar
Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)
Contributor
|
PR has been updated. Reviewers, please be cautious. |
alexanderchan-scality
force-pushed
the
bf/ZENKO-250-regexEval
branch
from
5f4cc79 to
e4e1354
Compare
Contributor
|
PR has been updated. Reviewers, please be cautious. |
alexanderchan-scality
force-pushed
the
bf/ZENKO-250-regexEval
branch
from
e4e1354 to
3a8da01
Compare
Contributor
|
PR has been updated. Reviewers, please be cautious. |
Original code will evaluate regex in `/pattern/` syntax incorrectly Adds parser to have MD search recognize if a regex is in `/pattern/` syntax or a simple string
alexanderchan-scality
force-pushed
the
bf/ZENKO-250-regexEval
branch
from
3a8da01 to
ba820e5
Compare
Contributor
|
PR has been updated. Reviewers, please be cautious. |
rahulreddy
approved these changes
Apr 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original code will evaluate regex in
/pattern/syntax incorrectlyAdds parser to have MD search recognize if a regex is in
/pattern/syntax ora simple string