Skip to content

ft: ZENKO-319 adds sproxyd location type management #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2018
Merged

ft: ZENKO-319 adds sproxyd location type management #1242

merged 1 commit into from
Jun 7, 2018

Conversation

@alexanderchan-scality
Copy link
Contributor

@alexanderchan-scality alexanderchan-scality commented May 9, 2018

No description provided.

@alexanderchan-scality alexanderchan-scality force-pushed the ft/ZENKO-319-sproxydLocationType branch from 83986f9 to 773ae09 Compare May 9, 2018 22:59
@ironman-machine
Copy link
Contributor

ironman-machine commented May 9, 2018

PR has been updated. Reviewers, please be cautious.

jonathan-gramain
jonathan-gramain requested changes May 9, 2018
View reviewed changes
lib/management/configuration.js Outdated
break;
case 'location-scality-sproxyd-v1':
location.type = 'scality';
if (l.details && l.details.bootstrap && l.detaisl.path) {
Copy link
Contributor

@jonathan-gramain jonathan-gramain May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, should be l.details.path

@alexanderchan-scality alexanderchan-scality force-pushed the ft/ZENKO-319-sproxydLocationType branch from 773ae09 to c88c69b Compare May 10, 2018 00:14
@ironman-machine
Copy link
Contributor

ironman-machine commented May 10, 2018

PR has been updated. Reviewers, please be cautious.

jonathan-gramain
jonathan-gramain reviewed May 10, 2018
View reviewed changes
lib/management/configuration.js
locations.details = {
connector: {
sproxyd: {
chordCos: l.details.chordCos || null,
Copy link
Contributor

@jonathan-gramain jonathan-gramain May 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add ARC support here as well, or not (@rachedbenmustapha ?)

Copy link
Contributor

@rachedbenmustapha rachedbenmustapha May 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathan-gramain you're the sproxyd guru so correct me if I'm wrong :) We rely on already-deployed sproxyd and I believe ARC settings will be bound to the proxyPath we are clients of.

Copy link
Contributor

@jonathan-gramain jonathan-gramain May 15, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, since we're using the proxyPath to an existing sproxyd that's what matters. But then is the chord COS used at all, aren't we passing the object bucket/key in the path directly?

Copy link
Contributor

@rachedbenmustapha rachedbenmustapha Jun 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathan-gramain chord cos is passed to sproxydclient

@alexanderchan-scality alexanderchan-scality force-pushed the ft/ZENKO-319-sproxydLocationType branch from c88c69b to 85d3d40 Compare May 11, 2018 18:59
@ironman-machine ironman-machine dismissed stale reviews from rachedbenmustapha and jonathan-gramain May 11, 2018 18:59

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented May 11, 2018

PR has been updated. Reviewers, please be cautious.

@alexanderchan-scality alexanderchan-scality force-pushed the ft/ZENKO-319-sproxydLocationType branch from 85d3d40 to b3d72a4 Compare May 14, 2018 16:02
@ironman-machine
Copy link
Contributor

ironman-machine commented May 14, 2018

PR has been updated. Reviewers, please be cautious.

@alexanderchan-scality alexanderchan-scality force-pushed the ft/ZENKO-319-sproxydLocationType branch from b3d72a4 to bc62d99 Compare June 5, 2018 19:00
@ironman-machine
Copy link
Contributor

ironman-machine commented Jun 5, 2018

PR has been updated. Reviewers, please be cautious.

@ironman-machine
Copy link
Contributor

ironman-machine commented Jun 5, 2018 

CONFLICT (add/add): Merge conflict in tests/unit/api/bucketACLauth.js
CONFLICT (add/add): Merge conflict in package.json
CONFLICT (add/add): Merge conflict in lib/api/objectGet.js
CONFLICT (add/add): Merge conflict in lib/api/apiUtils/bucket/bucketCreation.js
CONFLICT (add/add): Merge conflict in lib/api/apiUtils/authorization/aclChecks.js

@alexanderchan-scality alexanderchan-scality changed the base branch from z/1.0 to development/8.0 June 5, 2018 19:00
@alexanderchan-scality alexanderchan-scality force-pushed the ft/ZENKO-319-sproxydLocationType branch from bc62d99 to d0d6acf Compare June 6, 2018 23:05
@ironman-machine
Copy link
Contributor

ironman-machine commented Jun 6, 2018

PR has been updated. Reviewers, please be cautious.

@alexanderchan-scality alexanderchan-scality force-pushed the ft/ZENKO-319-sproxydLocationType branch from d0d6acf to 147f7dd Compare June 6, 2018 23:13
@ironman-machine
Copy link
Contributor

ironman-machine commented Jun 6, 2018

PR has been updated. Reviewers, please be cautious.

@rahulreddy
Copy link
Collaborator

rahulreddy commented Jun 7, 2018

@alexanderchan-scality Can you make this BertE compatible?

@alexanderchan-scality alexanderchan-scality force-pushed the ft/ZENKO-319-sproxydLocationType branch from 147f7dd to 323a69c Compare June 7, 2018 17:10
@ironman-machine ironman-machine dismissed stale reviews from jonathan-gramain and rachedbenmustapha June 7, 2018 17:10

Do it again human slave!:point_right: :runner: (Oh and the pull request has been updated, by the way.)

@ironman-machine
Copy link
Contributor

ironman-machine commented Jun 7, 2018

PR has been updated. Reviewers, please be cautious.

@rachedbenmustapha rachedbenmustapha merged commit 99d6f6f into development/8.0 Jun 7, 2018
@rachedbenmustapha rachedbenmustapha deleted the ft/ZENKO-319-sproxydLocationType branch June 7, 2018 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonathan-gramain jonathan-gramain jonathan-gramain approved these changes

+1 more reviewer

@rachedbenmustapha rachedbenmustapha rachedbenmustapha approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alexanderchan-scality @ironman-machine @rahulreddy @jonathan-gramain @rachedbenmustapha